Re: [PATCH v3] kni: fix possible alloc_q starvation when mbufs are exhausted

2023-03-11 Thread Thomas Monjalon
04/01/2023 15:34, Ferruh Yigit: > On 1/4/2023 11:57 AM, Matt wrote: > > Hi Ferruh, > > > > In my case, the traffic is not large, so I can't see the impact. > > I also tested under high load(>2Mpps with 2 DPDK cores and 2 kernel threads) > > and found no significant difference in performance either

Re: [PATCH v3] kni: fix possible alloc_q starvation when mbufs are exhausted

2023-01-04 Thread Ferruh Yigit
On 1/4/2023 11:57 AM, Matt wrote: > Hi Ferruh, > > In my case, the traffic is not large, so I can't see the impact. > I also tested under high load(>2Mpps with 2 DPDK cores and 2 kernel threads) > and found no significant difference in performance either. > I think the reason should be that it wil

Re: [PATCH v3] kni: fix possible alloc_q starvation when mbufs are exhausted

2023-01-04 Thread Matt
Hi Ferruh, In my case, the traffic is not large, so I can't see the impact. I also tested under high load(>2Mpps with 2 DPDK cores and 2 kernel threads) and found no significant difference in performance either. I think the reason should be that it will not run to 'kni_fifo_count(kni->alloc_q) ==

Re: [PATCH v3] kni: fix possible alloc_q starvation when mbufs are exhausted

2023-01-03 Thread Ferruh Yigit
On 12/30/2022 4:23 AM, Yangchao Zhou wrote: > In some scenarios, mbufs returned by rte_kni_rx_burst are not freed > immediately. So kni_allocate_mbufs may be failed, but we don't know. > > Even worse, when alloc_q is completely exhausted, kni_net_tx in > rte_kni.ko will drop all tx packets. kni_al