RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-20 Thread Akhil Goyal
Hi Ray, > >> > > > +RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY, > >> > > > +/** Hard byte expiry of SA */ > >> > > > +RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY, > >> > > > +/** Hard packet expiry of SA */ > >> > > > +RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY, > >> > > > >> > > Same comment fo

Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Ray Kinsella
Akhil Goyal writes: >> > Time expiry means after x seconds SA will expire. >> > Packet expiry means after x packets processing SA will expire. >> > Byte expiry means after x bytes of packet processing SA will expire. >> >> I think you should use the syntax @ref packets_soft_limit >> so it is c

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Akhil Goyal
> > Time expiry means after x seconds SA will expire. > > Packet expiry means after x packets processing SA will expire. > > Byte expiry means after x bytes of packet processing SA will expire. > > I think you should use the syntax @ref packets_soft_limit > so it is clear where the event come from

Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Thomas Monjalon
19/04/2022 12:14, Akhil Goyal: > Hi Thomas, > > > 16/04/2022 21:25, Akhil Goyal: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > > /** Soft byte expiry of SA */

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Anoob Joseph
vid.march...@redhat.com; hemant.agra...@nxp.com; > konstantin.anan...@intel.com; ciara.po...@intel.com; > ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > > Subject: Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry

Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Thomas Monjalon
19/04/2022 12:19, Anoob Joseph: > Hi Thomas, Akhil, > > > Is there a reference explaining what exactly is a "soft packet expiry"? > > The SA lifetime/expiry is described in security library. > https://elixir.bootlin.com/dpdk/latest/source/lib/security/rte_security.h#L295 The comment you are refe

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Anoob Joseph
ru; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > > Subject: RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event > subtypes > > Hi Thomas, > > > 16/04/2022 21:25, Akhil Goyal: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Akhil Goyal
Hi Thomas, > 16/04/2022 21:25, Akhil Goyal: > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > /** Soft byte expiry of SA */ > > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY

Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Thomas Monjalon
16/04/2022 21:25, Akhil Goyal: > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > /** Soft byte expiry of SA */ > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > + /** Soft p