Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-31 Thread Maxime Coquelin
On 1/19/23 19:46, David Marchand wrote: clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes into our ow

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-26 Thread David Marchand
On Thu, Jan 19, 2023 at 10:50 PM Tyler Retzlaff wrote: > > > we briefly touched on abstracting annotations in another thread. it > > > would be favorable if annotations were stashed behind macros that could > > > be expanded for more than just clang/internal/under doxygen to make > > > available o

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-19 Thread Tyler Retzlaff
On Thu, Jan 19, 2023 at 10:16:35PM +0100, David Marchand wrote: > On Thu, Jan 19, 2023 at 9:39 PM Tyler Retzlaff > wrote: > > > > On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > > > On Thu, 19 Jan 2023 19:46:12 +0100 > > > David Marchand wrote: > > > > > > > +#ifndef __DOXYGE

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-19 Thread David Marchand
On Thu, Jan 19, 2023 at 9:39 PM Tyler Retzlaff wrote: > > On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > > On Thu, 19 Jan 2023 19:46:12 +0100 > > David Marchand wrote: > > > > > +#ifndef __DOXYGEN__ > > > + __rte_exclusive_lock_function(&seqlock->lock) > > > +#endif > > >

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-19 Thread David Marchand
On Thu, Jan 19, 2023 at 8:42 PM Stephen Hemminger wrote: > > On Thu, 19 Jan 2023 19:46:12 +0100 > David Marchand wrote: > > > +#ifndef __DOXYGEN__ > > + __rte_exclusive_lock_function(&seqlock->lock) > > +#endif > > { > > Would be cleaner any required ifdefs was in rte_lock_annotations > rath

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-19 Thread Tyler Retzlaff
On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > On Thu, 19 Jan 2023 19:46:12 +0100 > David Marchand wrote: > > > +#ifndef __DOXYGEN__ > > + __rte_exclusive_lock_function(&seqlock->lock) > > +#endif > > { > > Would be cleaner any required ifdefs was in rte_lock_annotations

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

2023-01-19 Thread Stephen Hemminger
On Thu, 19 Jan 2023 19:46:12 +0100 David Marchand wrote: > clang offers some thread safety checks, statically verifying that locks > are taken and released in the code. > To use those checks, the full code leading to taking or releasing locks > must be annotated with some attributes. > > Wrap th