Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Stephen Hemminger
On Mon, 7 Feb 2022 18:28:03 + Akhil Goyal wrote: > > On Mon, 7 Feb 2022 17:28:26 + > > Ferruh Yigit wrote: > > > > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > > > On Sat, 5 Feb 2022 03:43:33 +0530 > > > > Akhil Goyal wrote: > > > > > > > >> +/** > > > >> + * @internal > >

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On Mon, 7 Feb 2022 17:28:26 + > Ferruh Yigit wrote: > > > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > > On Sat, 5 Feb 2022 03:43:33 +0530 > > > Akhil Goyal wrote: > > > > > >> +/** > > >> + * @internal > > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete > cas

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Stephen Hemminger
On Mon, 7 Feb 2022 17:28:26 + Ferruh Yigit wrote: > On 2/7/2022 5:23 PM, Stephen Hemminger wrote: > > On Sat, 5 Feb 2022 03:43:33 +0530 > > Akhil Goyal wrote: > > > >> +/** > >> + * @internal > >> + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > >> + */ > >> +

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On Sat, 5 Feb 2022 03:43:33 +0530 > Akhil Goyal wrote: > > > +/** > > + * @internal > > + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > > + */ > > +__rte_internal > > +int > > +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); > > Maybe use RTE_INI

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 5:23 PM, Stephen Hemminger wrote: On Sat, 5 Feb 2022 03:43:33 +0530 Akhil Goyal wrote: +/** + * @internal + * Register mbuf dynamic field and flag for IP reassembly incomplete case. + */ +__rte_internal +int +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); Maybe

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Stephen Hemminger
On Sat, 5 Feb 2022 03:43:33 +0530 Akhil Goyal wrote: > +/** > + * @internal > + * Register mbuf dynamic field and flag for IP reassembly incomplete case. > + */ > +__rte_internal > +int > +rte_eth_ip_reass_dynfield_register(int *field_offset, int *flag); Maybe use RTE_INIT() constructor for this

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
s.ru; rosen...@intel.com; > david.march...@redhat.com; radu.nico...@intel.com; Jerin Jacob > Kollanukkaran ; step...@networkplumber.org; > m...@ashroe.eu > Subject: Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for > incomplete IP reassembly > > On 2/7/2022 4:20 PM

Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 4:20 PM, Akhil Goyal wrote: On 2/7/2022 2:20 PM, Akhil Goyal wrote: On 2/4/2022 10:13 PM, Akhil Goyal wrote: Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets a

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On 2/7/2022 2:20 PM, Akhil Goyal wrote: > >> On 2/4/2022 10:13 PM, Akhil Goyal wrote: > >>> Hardware IP reassembly may be incomplete for multiple reasons like > >>> reassembly timeout reached, duplicate fragments, etc. > >>> To save application cycles to process these packets again, a new > >>> m

Re: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/7/2022 2:20 PM, Akhil Goyal wrote: On 2/4/2022 10:13 PM, Akhil Goyal wrote: Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show

RE: [EXT] Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Akhil Goyal
> On 2/4/2022 10:13 PM, Akhil Goyal wrote: > > Hardware IP reassembly may be incomplete for multiple reasons like > > reassembly timeout reached, duplicate fragments, etc. > > To save application cycles to process these packets again, a new > > mbuf dynflag is added to show that the mbuf received i

Re: [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-02-07 Thread Ferruh Yigit
On 2/4/2022 10:13 PM, Akhil Goyal wrote: Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show that the mbuf received is not reassemble