RE: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
Hi David, > On Tue, Feb 8, 2022 at 2:19 PM Akhil Goyal wrote: > > > > > I tried this in the first place but abi check was complaining in other > structures > > > > which included > > > > > rte_security_ipsec_sa_options. So I had to add suppression for those > > > > > as > well. > > > > > Can you

Re: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread David Marchand
On Tue, Feb 8, 2022 at 2:19 PM Akhil Goyal wrote: > > > > I tried this in the first place but abi check was complaining in other > > > > structures > > > which included > > > > rte_security_ipsec_sa_options. So I had to add suppression for those as > > > > well. > > > > Can you try at your end?

RE: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
Hi David, > > > > > diff --git a/devtools/libabigail.abignore > > > > > b/devtools/libabigail.abignore > > > > > index 4b676f317d..3bd39042e8 100644 > > > > > --- a/devtools/libabigail.abignore > > > > > +++ b/devtools/libabigail.abignore > > > > > @@ -11,3 +11,17 @@ > > > > > ; Ignore generated

RE: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
> > > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > > > index 4b676f317d..3bd39042e8 100644 > > > > --- a/devtools/libabigail.abignore > > > > +++ b/devtools/libabigail.abignore > > > > @@ -11,3 +11,17 @@ > > > > ; Ignore generated PMD information strings > > > >

Re: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread David Marchand
On Tue, Feb 8, 2022 at 10:19 AM Akhil Goyal wrote: > > > Hello Akhil, > > > > > > On Fri, Feb 4, 2022 at 11:14 PM Akhil Goyal wrote: > > > > > > A new option is added in IPsec to enable and attempt reassembly > > > of inbound packets. > > > > First, about extending this structure. > > > > Copying

RE: [EXT] Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread Akhil Goyal
> Hello Akhil, > > > On Fri, Feb 4, 2022 at 11:14 PM Akhil Goyal wrote: > > > > A new option is added in IPsec to enable and attempt reassembly > > of inbound packets. > > First, about extending this structure. > > Copying the header: > > /** Reserved bit fields for future extension >

Re: [PATCH v4 3/3] security: add IPsec option for IP reassembly

2022-02-08 Thread David Marchand
Hello Akhil, On Fri, Feb 4, 2022 at 11:14 PM Akhil Goyal wrote: > > A new option is added in IPsec to enable and attempt reassembly > of inbound packets. First, about extending this structure. Copying the header: /** Reserved bit fields for future extension * * User