: [PATCH v5] mempool cache: add zero-copy get and put functions
On Mon, Jan 23, 2023 at 01:23:50PM +0100, Morten Br�rup wrote:
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> > Sent: Monday, 23 January 2023 12.54
> >
> > > > Few nits, see below.
&g
On Mon, Jan 23, 2023 at 01:23:50PM +0100, Morten Brørup wrote:
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> > Sent: Monday, 23 January 2023 12.54
> >
> > > > Few nits, see below.
> > > > Also I still think we do need a test case for _zc_get_ before
> > > > accepting it in
> > > > > @@ -1364,32 +1556,25 @@ rte_mempool_do_generic_put(struct
> > rte_mempool
> > > > *mp, void * const *obj_table,
> > > > > {
> > > > > void **cache_objs;
> > > > >
> > > > > - /* No cache provided */
> > > > > - if (unlikely(cache == NULL))
> > > > > - goto dr
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> Sent: Monday, 23 January 2023 12.54
>
> > > Few nits, see below.
> > > Also I still think we do need a test case for _zc_get_ before
> > > accepting it in the mainline.
> >
> > Poking at my bad conscience... :-)
> >
> > It's on my
> > Few nits, see below.
> > Also I still think we do need a test case for _zc_get_ before
> > accepting it in the mainline.
>
> Poking at my bad conscience... :-)
>
> It's on my todo-list. Apparently not high enough. ;-)
>
> > With that in place:
> > Acked-by: Konstantin Ananyev
> >
> > > Ze
> From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru]
> Sent: Sunday, 22 January 2023 21.35
>
> Hi Morten,
>
> Few nits, see below.
> Also I still think we do need a test case for _zc_get_ before
> accepting it in the mainline.
Poking at my bad conscience... :-)
It's on my todo-lis
Hi Morten,
Few nits, see below.
Also I still think we do need a test case for _zc_get_ before
accepting it in the mainline.
With that in place:
Acked-by: Konstantin Ananyev
Zero-copy access to mempool caches is beneficial for PMD performance, and
must be provided by the mempool library to fix
7 matches
Mail list logo
