Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-29 Thread Dodji Seketeli
David Marchand writes: > On Wed, Feb 28, 2024 at 3:04 PM Dodji Seketeli wrote: >> > Btw, I see no way to suppress this (except a global [suppress_type] >> > name = rte_mbuf)... >> >> Right. >> >> To avoid having subsequent changes to that type from being "overly" >> suppressed, maybe do somethin

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread Tyler Retzlaff
On Wed, Feb 28, 2024 at 03:18:40PM +0100, David Marchand wrote: > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > wrote: > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. > > > > Maintain alignment of fields after removed cache

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread David Marchand
On Wed, Feb 28, 2024 at 4:01 PM Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Wednesday, 28 February 2024 15.19 > > > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > > wrote: > > > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC

RE: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 28 February 2024 15.19 > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > wrote: > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. > > > > Maintain

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread David Marchand
On Wed, Feb 28, 2024 at 3:04 PM Dodji Seketeli wrote: > > Btw, I see no way to suppress this (except a global [suppress_type] > > name = rte_mbuf)... > > Right. > > To avoid having subsequent changes to that type from being "overly" > suppressed, maybe do something like: > > [suppress_type] >

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread David Marchand
On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff wrote: > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Update imp

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread Dodji Seketeli
Hello, David Marchand writes: > Hello Dodji, o/ [...] > This change is reported as a potential ABI change. > > For the context, this patch > https://patchwork.dpdk.org/project/dpdk/patch/1709012499-12813-21-git-send-email-roret...@linux.microsoft.com/ > removes null-sized markers (those fiel

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-28 Thread David Marchand
On Tue, Feb 27, 2024 at 6:23 PM Tyler Retzlaff wrote: > > On Tue, Feb 27, 2024 at 04:18:10PM +0100, David Marchand wrote: > > Hello Dodji, > > > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > > wrote: > > > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > > RTE_MA

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-27 Thread Tyler Retzlaff
On Tue, Feb 27, 2024 at 04:18:10PM +0100, David Marchand wrote: > Hello Dodji, > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > wrote: > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. > > > > Maintain alignment of fields a

RE: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-27 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 27 February 2024 16.18 > > Hello Dodji, > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > wrote: > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. >

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-27 Thread David Marchand
Hello Dodji, On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff wrote: > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE).

RE: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-27 Thread Konstantin Ananyev
> Subject: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MI

RE: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

2024-02-27 Thread Morten Brørup
> @@ -607,8 +603,7 @@ struct rte_mbuf { > struct rte_mempool *pool; /**< Pool from which mbuf was allocated. */ > > /* second cache line - fields only used in slow path or on TX */ > - RTE_MARKER cacheline1 __rte_cache_min_aligned; > - > + alignas(RTE_CACHE_LINE_MIN_SIZE) This