Re: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation

2020-12-04 Thread George Prekas
On 12/4/2020 2:59 AM, Ferruh Yigit wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On 12/3/2020 1:59 PM, George Prekas wrote: Insert a compiler barrier to make su

Re: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation

2020-12-04 Thread Ferruh Yigit
On 12/3/2020 1:59 PM, George Prekas wrote: Insert a compiler barrier to make sure that the IP checksum calculation happens after setting all the fields of the IP header. Can you please provide the compiler details, and if there is any specific instruction on how to reproduce this failure?

Re: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation

2020-12-03 Thread Stephen Hemminger
On Thu, 3 Dec 2020 10:35:50 -0600 George Prekas wrote: > On 12/3/2020 10:08 AM, Stephen Hemminger wrote: > > On Thu, 3 Dec 2020 07:59:54 -0600 > > George Prekas wrote: > > > >> Insert a compiler barrier to make sure that the IP checksum calculation > >> happens after setting all the fields of

Re: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation

2020-12-03 Thread George Prekas
On 12/3/2020 10:08 AM, Stephen Hemminger wrote: On Thu, 3 Dec 2020 07:59:54 -0600 George Prekas wrote: Insert a compiler barrier to make sure that the IP checksum calculation happens after setting all the fields of the IP header. Signed-off-by: George Prekas I don't think this is necessary.

Re: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation

2020-12-03 Thread Stephen Hemminger
On Thu, 3 Dec 2020 07:59:54 -0600 George Prekas wrote: > Insert a compiler barrier to make sure that the IP checksum calculation > happens after setting all the fields of the IP header. > > Signed-off-by: George Prekas I don't think this is necessary. All other OS's don't have to do this. The