Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-31 Thread Ferruh Yigit
On 1/13/2017 4:12 PM, Ferruh Yigit wrote: > On 1/13/2017 4:01 PM, Jerin Jacob wrote: >> On Fri, Jan 13, 2017 at 03:57:59PM +, Ferruh Yigit wrote: >>> On 1/13/2017 3:53 PM, Thomas Monjalon wrote: 2017-01-13 08:51, Jerin Jacob: > On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wro

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Thomas Monjalon
2017-01-12 13:16, Jerin Jacob: > By introducing explicit -lrte_pmd_ixgbe link request in > testpmd Makefile,"-Wl,-lrte_pmd_ixgbe" provided twice, and linker > removes the duplication by keeping only first occurrence. > This moves "-Wl,-lrte_pmd_ixgbe" out of "-Wl,--whole-archive" flag > and makes s

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 4:01 PM, Jerin Jacob wrote: > On Fri, Jan 13, 2017 at 03:57:59PM +, Ferruh Yigit wrote: >> On 1/13/2017 3:53 PM, Thomas Monjalon wrote: >>> 2017-01-13 08:51, Jerin Jacob: On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > On 1/12/2017 1:58 PM, Jerin Jacob wrot

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 04:53:46PM +0100, Thomas Monjalon wrote: > 2017-01-13 08:51, Jerin Jacob: > > On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > > > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > > > >> 2017-0

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 03:57:59PM +, Ferruh Yigit wrote: > On 1/13/2017 3:53 PM, Thomas Monjalon wrote: > > 2017-01-13 08:51, Jerin Jacob: > >> On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > >>> On 1/12/2017 1:58 PM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 10:26:08AM

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 3:53 PM, Thomas Monjalon wrote: > 2017-01-13 08:51, Jerin Jacob: >> On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: >>> On 1/12/2017 1:58 PM, Jerin Jacob wrote: On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > 2017-01-12 13:16, Jerin Jacob:

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Thomas Monjalon
2017-01-13 08:51, Jerin Jacob: > On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > > >> 2017-01-12 13:16, Jerin Jacob: > > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Jerin Jacob
On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > >> 2017-01-12 13:16, Jerin Jacob: > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_P

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Ferruh Yigit
On 1/12/2017 1:58 PM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: >> 2017-01-12 13:16, Jerin Jacob: >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >>> _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe >>> +endif >> >> _LDLIBS is an internal variable

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Jerin Jacob
On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > 2017-01-12 13:16, Jerin Jacob: > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > +endif > > _LDLIBS is an internal variable of rte.app.mk. > Please could you check that

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-12 Thread Thomas Monjalon
2017-01-12 13:16, Jerin Jacob: > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > +endif _LDLIBS is an internal variable of rte.app.mk. Please could you check that there is no issue when using LDLIBS instead of _LDLIBS? Thanks