Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Thomas Monjalon
25/02/2021 13:05, Bruce Richardson: > On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote: > > 25/02/2021 12:57, Bruce Richardson: > > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > > > 25/02/2021 12:14, David Marchand: > > > > > Add a check on versioned symbol d

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 01:01:10PM +0100, Thomas Monjalon wrote: > 25/02/2021 12:57, Bruce Richardson: > > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > > 25/02/2021 12:14, David Marchand: > > > > Add a check on versioned symbol duplicates in map files. > > > > > > > > Signe

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Thomas Monjalon
25/02/2021 12:57, Bruce Richardson: > On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > > 25/02/2021 12:14, David Marchand: > > > Add a check on versioned symbol duplicates in map files. > > > > > > Signed-off-by: David Marchand > > > --- > > > This check could be added to buildt

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Bruce Richardson
On Thu, Feb 25, 2021 at 12:41:16PM +0100, Thomas Monjalon wrote: > 25/02/2021 12:14, David Marchand: > > Add a check on versioned symbol duplicates in map files. > > > > Signed-off-by: David Marchand > > --- > > This check could be added to buildtools/check-symbols.sh so that > > regular develope

Re: [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map

2021-02-25 Thread Thomas Monjalon
25/02/2021 12:14, David Marchand: > Add a check on versioned symbol duplicates in map files. > > Signed-off-by: David Marchand > --- > This check could be added to buildtools/check-symbols.sh so that > regular developers catch the issue when building their changes... > Opinions? In general I am