Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-13 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tyler Retzlaff > Sent: Friday, March 12, 2021 7:40 PM > > On Fri, Mar 12, 2021 at 10:36:15AM -0800, Tyler Retzlaff wrote: > > On Fri, Mar 12, 2021 at 05:37:41PM +, Bruce Richardson wrote: > > > On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyl

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 10:36:15AM -0800, Tyler Retzlaff wrote: > On Fri, Mar 12, 2021 at 05:37:41PM +, Bruce Richardson wrote: > > On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyler Retzlaff wrote: > > > > Not sure i agree. It's a very common pattern and is widely used and > > > > understood. I m

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 05:37:41PM +, Bruce Richardson wrote: > On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyler Retzlaff wrote: > > > Not sure i agree. It's a very common pattern and is widely used and > > > understood. I mean, if anything, seeing `~0` would have me stop and > > > think as i've

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Bruce Richardson
On Fri, Mar 12, 2021 at 09:05:58AM -0800, Tyler Retzlaff wrote: > On Fri, Mar 12, 2021 at 12:51:46PM +, Burakov, Anatoly wrote: > > On 09-Mar-21 11:44 PM, Tyler Retzlaff wrote: > > >use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign > > >to integer literal where the desire

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Tyler Retzlaff
On Fri, Mar 12, 2021 at 12:51:46PM +, Burakov, Anatoly wrote: > On 09-Mar-21 11:44 PM, Tyler Retzlaff wrote: > >use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign > >to integer literal where the desired type is unsigned. > > > >Signed-off-by: Tyler Retzlaff > >--- > > No

Re: [dpdk-dev] [PATCH] eal, power: don't use '-' sign with unsigned literals

2021-03-12 Thread Burakov, Anatoly
On 09-Mar-21 11:44 PM, Tyler Retzlaff wrote: use ~0ULL instead of -1ULL to avoid contridctory application of '-' sign to integer literal where the desired type is unsigned. Signed-off-by: Tyler Retzlaff --- Not sure i agree. It's a very common pattern and is widely used and understood. I mea