Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-10-13 Thread Shijith Thotton
On Tue, Oct 03, 2017 at 02:35:38PM +0300, Gregory Etelson wrote: > Hello, > > Can we hold with revert until proper solution will be introduced ? > > Regards, > Gregory > > On Monday, 2 October 2017 21:24:19 IDT Shijith Thotton wrote: > > On Fri, Sep 29, 2017 at 12:57:22PM +, Wu, Jingjing wro

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-10-03 Thread Gregory Etelson
Hello, Can we hold with revert until proper solution will be introduced ? Regards, Gregory On Monday, 2 October 2017 21:24:19 IDT Shijith Thotton wrote: > On Fri, Sep 29, 2017 at 12:57:22PM +, Wu, Jingjing wrote: > > Hi, Shijith > > > > Only removing the PCI reset in uio device open functio

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-10-02 Thread Shijith Thotton
On Fri, Sep 29, 2017 at 12:57:22PM +, Wu, Jingjing wrote: > Hi, Shijith > > Only removing the PCI reset in uio device open function is not enough. > > We faced an issue like: > > 1. Here is a FVL NIC, generate VF on one port, and then pass-through the VF > by vfio-pci to VM: > For example:

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-29 Thread Wu, Jingjing
Hi, Shijith Only removing the PCI reset in uio device open function is not enough. We faced an issue like: 1. Here is a FVL NIC, generate VF on one port, and then pass-through the VF by vfio-pci to VM: For example: echo 1 > /sys/bus/pci/devices/\:07\:00.1/sriov_numvfs modprobe vfio-pci echo

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-21 Thread Yang, Qiming
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Tuesday, September 19, 2017 6:24 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Thomas Monjalon > ; Yang, Qiming ; Patil, Harish > ; Zhang, Helin ; Gregory > Etelson ; Tan, Jianfeng ; Hu, > Xuekun

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-21 Thread Luca Boccassi
On Tue, 2017-09-19 at 15:54 +0530, Shijith Thotton wrote: > Issuing reset during uio device open caused PMD init failure for some > NIC VFs (i40, ixgbe, qede) in host. So this initial reset is removed. > Bus master enable is kept as part of open since we disable it in uio > device release. > > Fix

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-20 Thread Ferruh Yigit
On 9/19/2017 11:24 AM, Shijith Thotton wrote: > Issuing reset during uio device open caused PMD init failure for some > NIC VFs (i40, ixgbe, qede) in host. So this initial reset is removed. > Bus master enable is kept as part of open since we disable it in uio > device release. > > Fixes: b58eedfc