Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Stephen Hemminger
On Thu, 26 Apr 2018 14:42:31 +0100 Anatoly Burakov wrote: > rte_lcore_has_role() returns 0 if role of lcore matches requested > role. The return value of the API is confusing, and this is a known > problem with a deprecation notice announcing the change to more > intuitive semantics: > > Commit

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Stephen Hemminger
> Cc: Burakov, Anatoly ; dev@dpdk.org; Neil > > Horman ; Mcnamara, John > > ; Kovacevic, Marko > > ; Robert Sanford ; > > olivier.m...@6wind.com; shreyansh.j...@nxp.com > > Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function > > more intuitiv

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Carrillo, Erik G
rt Sanford ; > olivier.m...@6wind.com; shreyansh.j...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function > more intuitive > > 26/04/2018 16:44, Carrillo, Erik G: > > Thanks, Anatoly and Thomas. I had also considered the following chunk for

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Thomas Monjalon
26/04/2018 16:44, Carrillo, Erik G: > Thanks, Anatoly and Thomas. I had also considered the following chunk for > the release notes: > > diff --git a/doc/guides/rel_notes/release_18_05.rst > b/doc/guides/rel_notes/release_18_05.rst > index 04ff4fe..127a7e2 100644

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Carrillo, Erik G
nd.com; > shreyansh.j...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function > more intuitive > > 26/04/2018 15:42, Anatoly Burakov: > > rte_lcore_has_role() returns 0 if role of lcore matches requested > > role. The return value of t

Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

2018-04-26 Thread Thomas Monjalon
26/04/2018 15:42, Anatoly Burakov: > rte_lcore_has_role() returns 0 if role of lcore matches requested > role. The return value of the API is confusing, and this is a known > problem with a deprecation notice announcing the change to more > intuitive semantics: > > Commit 064518f68d48 ("doc: annou