Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: Doherty, Declan > Sent: Friday, April 28, 2017 3:57 PM > To: Trahe, Fiona; dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: Re: [PATCH] lib/cryptodev: fix API digest length comments > > On 25/04/2017 5:56 PM, Trahe, Fiona wrote: > > Fix mi

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Declan Doherty
On 25/04/2017 5:56 PM, Trahe, Fiona wrote: Fix misleading comments clarifying setting of digest length. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- ... Acked-by: Declan Doherty

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Declan Doherty
On 28/04/2017 2:38 PM, Trahe, Fiona wrote: Hi Declan, -Original Message- ... I don't think this comment change is valid, we already validate many of the parameters which are passed into session creation, such as key lengths etc, if we are not validating digest length now I think we s

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Trahe, Fiona
Hi Declan, > -Original Message- > From: Doherty, Declan > Sent: Friday, April 28, 2017 10:22 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: Re: [PATCH] lib/cryptodev: fix API digest length comments > > On 25/04/2017 5:56 PM, Trahe, Fiona wr

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-28 Thread Declan Doherty
On 25/04/2017 5:56 PM, Trahe, Fiona wrote: Fix misleading comments clarifying setting of digest length. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h | 11 ++-