Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Sure. On 17/09/2020 15:18, Burakov, Anatoly wrote: On 17-Sep-20 3:08 PM, Nick Connolly wrote: Excellent - thanks - I'll amend the patch. On 17/09/2020 15:07, Burakov, Anatoly wrote: On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA confi

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 3:08 PM, Nick Connolly wrote: Excellent - thanks - I'll amend the patch. On 17/09/2020 15:07, Burakov, Anatoly wrote: On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On 17/09/2020 13:57, Burakov, Anatoly wrote: On 17-Sep-20 1:29 PM, Nick Connolly wrote: Hi Anatoly, Thanks for the response.  You are

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Excellent - thanks - I'll amend the patch. On 17/09/2020 15:07, Burakov, Anatoly wrote: On 17-Sep-20 2:05 PM, Nick Connolly wrote: Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On 17/09/2020 13:57, Burakov, Anatoly wrote: O

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Hi Anatoly, Thanks.  My recollection is that all of the NUMA configuration flags were set to 'n'. Regards, Nick On 17/09/2020 13:57, Burakov, Anatoly wrote: On 17-Sep-20 1:29 PM, Nick Connolly wrote: Hi Anatoly, Thanks for the response.  You are asking a good question - here's what I know

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 17-Sep-20 1:29 PM, Nick Connolly wrote: Hi Anatoly, Thanks for the response.  You are asking a good question - here's what I know: The issue arose on a single socket system, running WSL2 (full Linux kernel running as a lightweight VM under Windows). The default kernel in this environment

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Nick Connolly
Hi Anatoly, Thanks for the response.  You are asking a good question - here's what I know: The issue arose on a single socket system, running WSL2 (full Linux kernel running as a lightweight VM under Windows). The default kernel in this environment is built with CONFIG_NUMA=n which means get

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 05-Aug-20 1:26 PM, Nick Connolly wrote: Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocating rte services array. alloc_seg() calls get_mempolicy to verify that the allocation has hap

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-09-17 Thread Burakov, Anatoly
On 05-Aug-20 4:21 PM, Nick Connolly wrote: On 05/08/2020 16:13, Nicolas Dichtel wrote: Le 05/08/2020 à 16:53, Nick Connolly a écrit : [snip] +    if (check_numa()) { +    ret = get_mempolicy(&cur_socket_id, NULL, 0, addr, +    MPOL_F_NODE | MPOL_F_ADDR); +    if (ret <

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-08-05 Thread Nick Connolly
On 05/08/2020 16:13, Nicolas Dichtel wrote: Le 05/08/2020 à 16:53, Nick Connolly a écrit : [snip] +    if (check_numa()) { +    ret = get_mempolicy(&cur_socket_id, NULL, 0, addr, +    MPOL_F_NODE | MPOL_F_ADDR); +    if (ret < 0) { +    RTE_LOG(DEBUG, EAL, "%s(

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-08-05 Thread Nicolas Dichtel
Le 05/08/2020 à 16:53, Nick Connolly a écrit : [snip] > +    if (check_numa()) { > +    ret = get_mempolicy(&cur_socket_id, NULL, 0, addr, > +    MPOL_F_NODE | MPOL_F_ADDR); > +    if (ret < 0) { > +    RTE_LOG(DEBUG, EAL, "%s(): get_mempolicy: %s

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-08-05 Thread Nick Connolly
On 05/08/2020 15:36, Nicolas Dichtel wrote: Le 05/08/2020 à 16:20, Nick Connolly a écrit : [snip] Fixes: 2a96c88be83e ("mem: ease init in a docker container") I'm wondering if the bug existed before this commit. Before this commit, it was:     move_pages(getpid(), 1, &addr, NULL, &cur_

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-08-05 Thread Nicolas Dichtel
Le 05/08/2020 à 16:20, Nick Connolly a écrit : [snip] >>> Fixes: 2a96c88be83e ("mem: ease init in a docker container") >> I'm wondering if the bug existed before this commit. >> >> Before this commit, it was: >>     move_pages(getpid(), 1, &addr, NULL, &cur_socket_id, 0); >>     if (cur_soc

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-08-05 Thread Nick Connolly
Hi Nicolas, Thanks for the quick response. On 05/08/2020 14:42, Nicolas Dichtel wrote: Le 05/08/2020 à 14:26, Nick Connolly a écrit : Running dpdk-helloworld on Linux with lib numa present, but no kernel support for NUMA (CONFIG_NUMA=n) causes ret_service_init() to fail with EAL: error allocat

Re: [dpdk-dev] [PATCH] mem: fix allocation failure on non-NUMA kernel

2020-08-05 Thread Nicolas Dichtel
Le 05/08/2020 à 14:26, Nick Connolly a écrit : > Running dpdk-helloworld on Linux with lib numa present, > but no kernel support for NUMA (CONFIG_NUMA=n) causes > ret_service_init() to fail with EAL: error allocating > rte services array. > > alloc_seg() calls get_mempolicy to verify that the allo