Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-20 Thread Xia, Chenbo
ath Kotur ; Thierry Herbelot > ; Xia, Chenbo ; dev > ; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat > 8 > > ::snip:: > > > > > > > This patch rang a bell. > > There is the exact same patch proposed by Xia with

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-18 Thread Ajit Khaparde
::snip:: > > > > This patch rang a bell. > There is the exact same patch proposed by Xia with a comment, so I > guess Xia is still working on it? > https://patchwork.dpdk.org/patch/75177/#117201 Xia, Will you submit the changes that Thomas asked for? Otherwise I will apply the bnxt patch and you ca

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-18 Thread Somnath Kotur
On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot wrote: > > .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function > ‘bnxt_ulp_destroy_df_rules’: > .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error: > comparison is always true due to limited range of data type > [-Werror=

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-18 Thread David Marchand
On Fri, Sep 18, 2020 at 9:12 AM Somnath Kotur wrote: > > On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot > wrote: > > > > .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function > > ‘bnxt_ulp_destroy_df_rules’: > > .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error: > > co

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error with some compilers

2019-06-13 Thread Thomas Monjalon
14/06/2019 13:20, Ajit Khaparde: > The driver was defining its own version of roundup which was > conflicting with another version defined elsewhere. > > Change the local definition of roundup to avoid compilation errors. > > Fixes: c5d09af8aa46 ("net/bnxt: support thor controller") Fixed the wr

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation

2017-10-10 Thread Ferruh Yigit
On 10/10/2017 8:40 AM, Kavanagh, Mark B wrote: >> From: Yigit, Ferruh >> Sent: Monday, October 9, 2017 6:34 PM >> To: Kavanagh, Mark B ; dev@dpdk.org >> Cc: ajit.khapa...@broadcom.com >> Subject: Re: [PATCH] net/bnxt: fix compilation >> >> On 10/9/2017 2:59 PM, Mark Kavanagh wrote: >>> As of 5ef3b7

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation

2017-10-10 Thread Kavanagh, Mark B
>From: Yigit, Ferruh >Sent: Monday, October 9, 2017 6:34 PM >To: Kavanagh, Mark B ; dev@dpdk.org >Cc: ajit.khapa...@broadcom.com >Subject: Re: [PATCH] net/bnxt: fix compilation > >On 10/9/2017 2:59 PM, Mark Kavanagh wrote: >> As of 5ef3b79fdfe6f, compilation of DPDK fails with the following >> erro

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 2:59 PM, Mark Kavanagh wrote: > As of 5ef3b79fdfe6f, compilation of DPDK fails with the following > error message: > "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this > function [-Werror=maybe-uninitialized]". > > Resolve this by initializing 'vnic' to NULL; > >