Re: [dpdk-dev] [PATCH] net/bonding: add add/remove mac addrs

2018-06-06 Thread Chas Williams
On Wed, Jun 6, 2018 at 7:52 AM, Alex Kiselev wrote: > Hi Chas. > > Thank you for the review. > > >This is fine but you are missing one bit. If a slave is added after you > can configured the MAC > >addresses, you will need to replay the configured MAC addresses into that > slave. > > Yeah, I've

Re: [dpdk-dev] [PATCH] net/bonding: add add/remove mac addrs

2018-06-06 Thread Alex Kiselev
Hi Chas. Thank you for the review. >This is fine but you are missing one bit. If a slave is added after you can >configured the MAC >addresses, you will need to replay the configured MAC addresses into that >slave. Yeah, I've missed that part about adding a slave when a bond is already workin

Re: [dpdk-dev] [PATCH] net/bonding: add add/remove mac addrs

2018-06-04 Thread Chas Williams
This is fine but you are missing one bit. If a slave is added after you can configured the MAC addresses, you will need to replay the configured MAC addresses into that slave. It's not clear to me what the contract is between bonding and DPDK as far as slave removal. Just looking at the behavior