Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-11-19 Thread Matan Azrad
+@Asaf Penso From: Benoit Ganne > >> 2. To change documentation of ethdev API to say that only link status > >> is mandatory report. (all others "nice to have" or "best effort"): > >>This is for you - I suggest to send prior patch to ethdev > >>for this and let the community to decide. >

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-04-07 Thread Benoit Ganne (bganne)
>> 2. To change documentation of ethdev API to say that only link status >> is mandatory report. (all others "nice to have" or "best effort"): >> This is for you - I suggest to send prior patch to ethdev >> for this and let the community to decide. > Matan, Benoit, I guess nobody tried to

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-04-07 Thread Thomas Monjalon
30/03/2020 18:13, Matan Azrad: > 2. To change documentation of ethdev API to say that only link status > is mandatory report. (all others "nice to have" or "best effort"): > This is for you - I suggest to send prior patch to ethdev > for this and let the community to decide. Matan, Ben

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-04-01 Thread Matan Azrad
Hi From: Benoit Ganne > Hi Matan, > > >> Seems to be a bug in kernel mlx5 driver: > > 1. To check with our driver team what is the issue to report a VF link Yes, driver team said the 3 kernel patches should solve the issue. > Note that even with the kernel patch, there still seem to be a valid

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-04-01 Thread Benoit Ganne (bganne)
Hi Matan, >> Seems to be a bug in kernel mlx5 driver: > 1. To check with our driver team what is the issue to report a VF link Note that even with the kernel patch, there still seem to be a valid case where it can return SPEED_UNKNOWN. If this is true, then I don't think we can rely on valid lin

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-30 Thread Matan Azrad
Hi From: Benoit Ganne (bganne) > > Why link speed is undefined? > > Old kernel? > > Kernel mlx5 driver issue? > > Do you know? > > Seems to be a bug in kernel mlx5 driver: > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmails. > dpdk.org%2Farchives%2Fusers%2F2020- > March%2F00

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-30 Thread Benoit Ganne (bganne)
> Why link speed is undefined? > Old kernel? > Kernel mlx5 driver issue? > Do you know? Seems to be a bug in kernel mlx5 driver: http://mails.dpdk.org/archives/users/2020-March/004758.html I still think this test is too strict, and from what I can see mlx4 PMD do not implement it (even if it use

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-30 Thread Matan Azrad
Hi From: Benoit Ganne > Sent: Monday, March 30, 2020 3:03 PM > To: Matan Azrad ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix link state update > > Hi Matan, > > >>>> mlx5 PMD refuses to update link state if link speed is defined but > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-30 Thread Benoit Ganne (bganne)
Hi Matan, mlx5 PMD refuses to update link state if link speed is defined but status is down or if link speed is undefined but status is up, even if the ioctl() succeeded. This prevents application to detect link up/down event, especially when the link speed is not correctl

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-30 Thread Matan Azrad
Hi From: Benoit Ganne (bganne) > > From: Matan Azrad > > >> From: Benoît Ganne > >> mlx5 PMD refuses to update link state if link speed is defined but > >> status is down or if link speed is undefined but status is up, even > >> if the ioctl() succeeded. > >> This prevents application to detect

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-30 Thread Benoit Ganne (bganne)
> From: Matan Azrad >> From: Benoît Ganne >> mlx5 PMD refuses to update link state if link speed is defined but >> status is down or if link speed is undefined but status is up, >> even if the ioctl() succeeded. >> This prevents application to detect link up/down event, especially >> when the lin

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-03-29 Thread Matan Azrad
Hi From: Benoît Ganne > mlx5 PMD refuses to update link state if link speed is defined but status is > down or if link speed is undefined but status is up, even if the ioctl() > succeeded. > This prevents application to detect link up/down event, especially when the > link speed is not correctly