Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, September 3, 2019 3:35 PM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN > insertions > > If VLAN tag insertion transmi

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-10 Thread Matan Azrad
From: Viacheslav Ovsiienko > If VLAN tag insertion transmit offload is engaged > (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the > transmit descriptor may be built with wrong format, due to packet length is > not adjusted. Also, the ring buffer wrapup is not handled correctly.

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-03 Thread Matan Azrad
Hi From: Slava Ovsiienko > Hi, Matan > > Please, see below. > > > -Original Message- > > From: Matan Azrad > > Sent: Tuesday, September 3, 2019 16:05 > > To: Slava Ovsiienko ; dev@dpdk.org > > Cc: sta...@dpdk.org > > Subject: RE: [PATCH] net/mlx5: fix transmit descriptor with VLAN > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-03 Thread Slava Ovsiienko
Hi, Matan Please, see below. > -Original Message- > From: Matan Azrad > Sent: Tuesday, September 3, 2019 16:05 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions > > Hi Slava > > From: Viacheslav Ovsi

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-03 Thread Matan Azrad
Hi Slava From: Viacheslav Ovsiienko > If VLAN tag insertion transmit offload is engaged > (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the > transmit descriptor may be built with wrong format, due to packet length is > not adjusted. Also, the ring buffer wrapup is not handled cor