Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code

2020-10-04 Thread Jerin Jacob
am ; Kiran Kumar K > > ; Lilijun (Jerry) ; > > xudingke ; dpdk stable > > Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code > > > > On Wed, Aug 26, 2020 at 4:48 PM wangyunjian > > wrote: > > > > > > From: Yunjian Wa

Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code

2020-09-30 Thread wangyunjian
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, September 30, 2020 2:15 AM > To: wangyunjian > Cc: dpdk-dev ; Jerin Jacob ; Nithin > Dabilpuram ; Kiran Kumar K > ; Lilijun (Jerry) ; > xudingke ; dpdk stable > Subject:

Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code

2020-09-29 Thread Stephen Hemminger
On Wed, 26 Aug 2020 19:18:09 +0800 wangyunjian wrote: > if (tx_qconf) > free(tx_qconf); > - if (rx_qconf) > - free(rx_qconf); free accepts a NULL pointer so current practice is to avoid useless if() tests before free.

Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code

2020-09-29 Thread Jerin Jacob
On Wed, Aug 26, 2020 at 4:48 PM wangyunjian wrote: > > From: Yunjian Wang > > Coverity issue: 357719 > Fixes: da138cd47e06 ("net/octeontx2: handle port reconfigure") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang > --- > drivers/net/octeontx2/otx2_ethdev.c | 2 -- > 1 file changed, 2 del