Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Maxime Coquelin
enko ; Vipul Ashri > ; dev@dpdk.org > Cc: chenbo@intel.com; zhihong.w...@intel.com; maxime.coque...@redhat.com; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in > helper macro > > > On 8/29/20 2:22 PM, Andrew Rybchenko

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Vipul Ashri
] Sent: Sunday, 30 August, 2020 3:48 To: Andrew Rybchenko ; Vipul Ashri ; dev@dpdk.org Cc: chenbo@intel.com; zhihong.w...@intel.com; maxime.coque...@redhat.com; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro On 8/29/20 2:22 PM, Andrew

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-09-18 Thread Vipul Ashri
] Sent: Saturday, 29 August, 2020 16:53 To: Vipul Ashri ; dev@dpdk.org Cc: chenbo@intel.com; zhihong.w...@intel.com; maxime.coque...@redhat.com; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro On 8/14/20 12:21 PM, Vipul Ashri wrote

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-08-29 Thread Edward Makarov
On 8/29/20 2:22 PM, Andrew Rybchenko wrote: > On 8/14/20 12:21 PM, Vipul Ashri wrote: >> Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always >> failing as assignment done using var_ having local scope only. >> This leads to TX packets not going out and found broken due to clean

Re: [dpdk-dev] [PATCH] net/virtio: fix wrong variable assignment in helper macro

2020-08-29 Thread Andrew Rybchenko
On 8/14/20 12:21 PM, Vipul Ashri wrote: > Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always > failing as assignment done using var_ having local scope only. > This leads to TX packets not going out and found broken due to cleanup > malfunctioning. This patch fixes the wrong va