Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-21 Thread Kozak, KubaX
Hi, Referring to Patrick suggestion I'll prepare patch with (fd >= 0) condition. Thanks, Kuba > -Original Message- > From: Patrick MacArthur [mailto:patr...@patrickmacarthur.net] > Sent: Thursday, September 21, 2017 04:28 > To: Burakov, Anatoly ; Kozak, KubaX > > Cc: dev@dpdk.org; sta

Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-20 Thread Patrick MacArthur
On 09/20/2017 10:39 AM, Burakov, Anatoly wrote: On 20-Sep-17 3:34 PM, Patrick MacArthur wrote: On 09/20/2017 05:59 AM, Kuba Kozak wrote: Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process

Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-20 Thread Burakov, Anatoly
On 20-Sep-17 3:34 PM, Patrick MacArthur wrote: On 09/20/2017 05:59 AM, Kuba Kozak wrote: Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dp

Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-20 Thread Patrick MacArthur
On 09/20/2017 05:59 AM, Kuba Kozak wrote: Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak --- lib/lib

Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-20 Thread Burakov, Anatoly
On 20-Sep-17 10:59 AM, Kuba Kozak wrote: Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak --- Acked-by