Re: [dpdk-dev] [PATCH] windows: minor build fixes

2020-10-30 Thread Nick Connolly
On 30/10/2020 22:51, Tal Shnaiderman wrote: Do we know why meson changed its behavior of lib file location in versions > 0.54? Was the old behavior of keeping lib files in the matching output folders incorrect? I'm not sure why meson was changed, but without the fix subsequent attempts to link

Re: [dpdk-dev] [PATCH] windows: minor build fixes

2020-10-30 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH] windows: minor build fixes > > > On 10/30/2020 10:46 AM, Nick Connolly wrote: > > Don't run symlink-drivers-solibs.sh as part of 'install' because > > Windows doesn't support shell scripts. > > > > Meson

Re: [dpdk-dev] [PATCH] windows: minor build fixes

2020-10-30 Thread Ranjit Menon
On 10/30/2020 10:46 AM, Nick Connolly wrote: Don't run symlink-drivers-solibs.sh as part of 'install' because Windows doesn't support shell scripts. Meson versions >= 0.54.0 include support for handling /implib with msvc link. Specifying it explicitly causes failures when linking against the d

Re: [dpdk-dev] [PATCH] windows: minor build fixes

2020-10-30 Thread Nick Connolly
Do we know what the motivation to rename the import library for the Windows build was in the first place? I've tried removing the renaming of the import library completely in the Windows build and the build produces valid output (a valid DLL and paired import library is generated for each RT

Re: [dpdk-dev] [PATCH] windows: minor build fixes

2020-10-30 Thread John Alexander
> -Original Message- > From: dev On Behalf Of Nick Connolly > Sent: 30 October 2020 17:46 > To: Bruce Richardson > Cc: dev@dpdk.org; Nick Connolly > Subject: [dpdk-dev] [PATCH] windows: minor build fixes > > CAUTION: This email originated from outside of the organization. Do not click >