Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-29 Thread Wiles, Keith
> On Mar 29, 2017, at 5:47 AM, Morten Brørup wrote: > > I have two points to this discussion: > > GRO/LRO must be disabled by default! Truly transparent network appliances, > such as classic Layer 3 routers and Layer 2 switches (and our SmartShare > StraightShaper appliance), may not want to

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-29 Thread Morten Brørup
I have two points to this discussion: GRO/LRO must be disabled by default! Truly transparent network appliances, such as classic Layer 3 routers and Layer 2 switches (and our SmartShare StraightShaper appliance), may not want to merge multiple smaller packets into one larger packet, regardless

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-28 Thread Wiles, Keith
chardson, Bruce ; Stephen Hemminger >> ; Yigit, Ferruh ; >> dev@dpdk.org; Liang, Cunming ; Thomas >> Monjalon >> Subject: Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support >> >> >>> On Mar 24, 2017, at 10:07 AM, Wiles, Keith wrote: >>> &

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-28 Thread Hu, Jiayu
s > Monjalon > Subject: Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support > > > > On Mar 24, 2017, at 10:07 AM, Wiles, Keith wrote: > > > >> > >> On Mar 24, 2017, at 9:59 AM, Olivier Matz > wrote: > >> > >> On Fri, 24 Mar

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-28 Thread Wiles, Keith
> On Mar 24, 2017, at 10:07 AM, Wiles, Keith wrote: > >> >> On Mar 24, 2017, at 9:59 AM, Olivier Matz wrote: >> >> On Fri, 24 Mar 2017 14:37:04 +, "Wiles, Keith" >> wrote: On Mar 24, 2017, at 6:43 AM, Ananyev, Konstantin wrote: >> >> [...] >> Yep, th

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-24 Thread Wiles, Keith
> On Mar 24, 2017, at 9:59 AM, Olivier Matz wrote: > > On Fri, 24 Mar 2017 14:37:04 +, "Wiles, Keith" > wrote: >>> On Mar 24, 2017, at 6:43 AM, Ananyev, Konstantin >>> wrote: >>> >>> >>> > > [...] > >>> Yep, that's what my take from the beginning: >>> Let's develop a librte_gro firs

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-24 Thread Olivier Matz
On Fri, 24 Mar 2017 14:37:04 +, "Wiles, Keith" wrote: > > On Mar 24, 2017, at 6:43 AM, Ananyev, Konstantin > > wrote: > > > > > > [...] > > Yep, that's what my take from the beginning: > > Let's develop a librte_gro first and make it successful, then we can think > > should > > we (

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-24 Thread Wiles, Keith
>> ; Stephen Hemminger >> ; Yigit, Ferruh ; >> dev@dpdk.org; Liang, Cunming ; Thomas Monjalon >> >> Subject: Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support >> >> On Fri, Mar 24, 2017 at 03:22:30PM +0800, Yuanhan Liu wrote: >>> On Fr

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-24 Thread Ananyev, Konstantin
> > Subject: Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support > > On Fri, Mar 24, 2017 at 03:22:30PM +0800, Yuanhan Liu wrote: > > On Fri, Mar 24, 2017 at 06:18:48AM +, Wiles, Keith wrote: > > > >> I think that having a separate library for GRO is a step i

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-24 Thread Jiayu Hu
On Fri, Mar 24, 2017 at 03:22:30PM +0800, Yuanhan Liu wrote: > On Fri, Mar 24, 2017 at 06:18:48AM +, Wiles, Keith wrote: > > >> I think that having a separate library for GRO is a step in a right > > >> direction. > > >>> From my perspective - it provides a clean and flexible way to use that

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-24 Thread Yuanhan Liu
On Fri, Mar 24, 2017 at 06:18:48AM +, Wiles, Keith wrote: > >> I think that having a separate library for GRO is a step in a right > >> direction. > >>> From my perspective - it provides a clean and flexible way to use that > >>> feature. > >> If later someone would like to put GRO into ethde

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-23 Thread Wiles, Keith
;>> Sent: Thursday, March 23, 2017 6:25 AM >>>>> To: Wiles, Keith >>>>> Cc: Yuanhan Liu ; Richardson, Bruce >>>>> ; Yigit, Ferruh ; >>>>> Ananyev, Konstantin >>>>> Subject: Re: [dpdk-dev] [PATCH 0/2] l

Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support

2017-03-23 Thread Jiayu Hu
ith > > > > Cc: Yuanhan Liu ; Richardson, Bruce > > > > ; Yigit, Ferruh ; > > > > Ananyev, Konstantin > > > > Subject: Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support > > > > > > > > On Thu, Mar 23, 2017 at 01:29:06PM