Re: [dpdk-dev] [PATCH 1/2] acl: remove use of weak functions

2019-04-10 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, April 10, 2019 2:45 PM > To: Ananyev, Konstantin ; acon...@redhat.com > Cc: dev@dpdk.org; Richardson, Bruce > Subject: [PATCH 1/2] acl: remove use of weak functions > > Weak functions don't work well with static librarie

Re: [dpdk-dev] [PATCH 1/2] acl: remove use of weak functions

2019-04-10 Thread Aaron Conole
Bruce Richardson writes: > On Wed, Apr 10, 2019 at 09:54:02AM -0400, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > Weak functions don't work well with static libraries and require the >> > use of "whole-archive" flag to ensure that the correct function is used >> > when linking. Since

Re: [dpdk-dev] [PATCH 1/2] acl: remove use of weak functions

2019-04-10 Thread Bruce Richardson
On Wed, Apr 10, 2019 at 09:54:02AM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > Weak functions don't work well with static libraries and require the > > use of "whole-archive" flag to ensure that the correct function is used > > when linking. Since the weak functions are only used

Re: [dpdk-dev] [PATCH 1/2] acl: remove use of weak functions

2019-04-10 Thread Aaron Conole
Bruce Richardson writes: > Weak functions don't work well with static libraries and require the use of > "whole-archive" flag to ensure that the correct function is used when > linking. Since the weak functions are only used as placeholders within > this library alone, we can replace them with no