Yes, I will add the document update when I send v2 out. Thanks
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Friday, March 1, 2019 9:40 PM
> To: Yang, Qiming
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: supppor
NACK, see comments below
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Friday, March 1, 2019 4:46 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming
> Subject: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download
>
> Columbiaville requires a p
On Fri, 1 Mar 2019 20:46:12 +0800
Qiming Yang wrote:
> +
> + if (kvargs_count > 1)
> + PMD_DRV_LOG(WARNING, "More than one argument \"%s\" and only "
> + "the first invalid or last valid one is used !",
Do not add line breaks to error message strings, it makes it har
On Fri, 1 Mar 2019 20:46:12 +0800
Qiming Yang wrote:
> static int
> +ice_parse_pkg_path_handler(__rte_unused const char *key,
> + const char *value,
> + void *opaque)
> +{
> + struct ice_adapter *ad;
> +
> + ad = (struct ice_adapter *)opaque;
01/03/2019 13:46, Qiming Yang:
> Columbiaville requires a package to be downloaded if need advanced
> features. This patch add package download support in two ways.
> If it configured package path in devargs, will use this path,
> if not, will load the package at /lib/firmware/intel/ice/ddp/ice.pkg
5 matches
Mail list logo
