Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-04-01 Thread Bruce Richardson
On Tue, Mar 23, 2021 at 09:38:25AM +, Bruce Richardson wrote: > On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote: > >Hi, > >Thanks for the review. > >I have some reservations about those TODO: they are about > >rewriting the same functionality with a newer meson fea

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-23 Thread Bruce Richardson
On Tue, Mar 23, 2021 at 07:22:00AM +0100, Gabriel Ganne wrote: >Hi, >Thanks for the review. >I have some reservations about those TODO: they are about >rewriting the same functionality with a newer meson feature. >No functional change is expected. => Why not write a commit that

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-23 Thread Dmitry Kozlyuk
2021-03-23 07:22 (UTC+0100), Gabriel Ganne: > Hi, > > Thanks for the review. > > I have some reservations about those TODO: they are about > rewriting the same functionality with a newer meson feature. > No functional change is expected. => Why not write a commit that > implements such a TODO and

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-23 Thread Andrew Rybchenko
On 3/23/21 9:22 AM, Gabriel Ganne wrote: > Hi, > > Thanks for the review. > > I have some reservations about those TODO: they are about > rewriting the same functionality with a newer meson feature. > No functional change is expected. => Why not write a commit that > implements such a TODO and bu

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Gabriel Ganne
Hi, Thanks for the review. I have some reservations about those TODO: they are about rewriting the same functionality with a newer meson feature. No functional change is expected. => Why not write a commit that implements such a TODO and bumps meson version at the same time independently ? In an

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Dmitry Kozlyuk
2021-03-22 09:34 (UTC+), Bruce Richardson: > On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > > in '0.48.0': console arg in custom_target > > > > console argument is used within kernel/linu

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread David Marchand
On Mon, Mar 22, 2021 at 9:39 AM Gabriel Ganne wrote: > > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > in '0.48.0': console arg in custom_target > > console argument is used within kernel/linux/kni/meson.build > > Signed-off-by: Gabriel Ganne > --- > meso

Re: [dpdk-dev] [PATCH 1/3] meson: fix minimum required meson version

2021-03-22 Thread Bruce Richardson
On Mon, Mar 22, 2021 at 09:38:59AM +0100, Gabriel Ganne wrote: > WARNING: Project targetting '>= 0.47.1' but tried to use feature introduced > in '0.48.0': console arg in custom_target > > console argument is used within kernel/linux/kni/meson.build > > Signed-off-by: Gabriel Ganne > --