Re: [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support

2019-03-01 Thread Luca Boccassi
On Fri, 2019-03-01 at 14:17 +, Bruce Richardson wrote: > On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote: > > 01/03/2019 08:18, Anand Rawat: > > > > > [...] > > > @@ -17,13 +17,19 @@ elif host_machine.system() == 'freebsd' > > > dpdk_conf.set('RTE_EXEC_ENV_BSDAPP', 1) subdir('b

Re: [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support

2019-03-01 Thread Thomas Monjalon
01/03/2019 15:17, Bruce Richardson: > On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote: > > 01/03/2019 08:18, Anand Rawat: > > > +elif host_machine.system() == 'windows' + > > > dpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1) > > > > For consistency, it should RTE_EXEC_ENV_WINAPP. > > > F

Re: [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support

2019-03-01 Thread Bruce Richardson
On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote: > 01/03/2019 08:18, Anand Rawat: > > Added initial stub source files for windows support and meson changes > > to build them. > > Thanks for sending some new patches based on meson. > > Let's start review with some simple considerat

Re: [dpdk-dev] [PATCH 1/6] eal: eal stub to add windows support

2019-03-01 Thread Thomas Monjalon
01/03/2019 08:18, Anand Rawat: > Added initial stub source files for windows support and meson > changes to build them. Thanks for sending some new patches based on meson. Let's start review with some simple considerations. > Signed-off-by: Anand Rawat > Signed-off-by: Kadam, Pallavi Please a