Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace

2020-04-26 Thread Dmitry Kozlyuk
On 2020-04-26 17:53 GMT+0530 Jerin Jacob wrote: > On Sun, Apr 26, 2020 at 5:32 PM Dmitry Kozlyuk > wrote: > > > > On 2020-04-26 17:02 GMT+0530 Jerin Jacob wrote: > > > > +/** > > > > + * Get absolute path to the directory where permanent data can be > > > > stored. > > > > + * > > > > + * @ret

Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace

2020-04-26 Thread Thomas Monjalon
26/04/2020 14:23, Jerin Jacob: > On Sun, Apr 26, 2020 at 5:32 PM Dmitry Kozlyuk > wrote: > > While we're at it, don't these declarations belong to eal_filesystem.h? I > > left them in eal_private.h, because eal_filesystem.h is mostly > > Unix-specific. Yes it looks to be a good fit for eal_file

Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace

2020-04-26 Thread Jerin Jacob
On Sun, Apr 26, 2020 at 5:32 PM Dmitry Kozlyuk wrote: > > On 2020-04-26 17:02 GMT+0530 Jerin Jacob wrote: > > > +/** > > > + * Get absolute path to the directory where permanent data can be stored. > > > + * > > > + * @return > > > + * Statically allocated string on success, NULL on failure. > >

Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace

2020-04-26 Thread Dmitry Kozlyuk
On 2020-04-26 17:02 GMT+0530 Jerin Jacob wrote: > > +/** > > + * Get absolute path to the directory where permanent data can be stored. > > + * > > + * @return > > + * Statically allocated string on success, NULL on failure. > > + */ > > +const char * > > +eal_permanent_data_path(void); > > Do

Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace

2020-04-26 Thread Jerin Jacob
On Sun, Apr 26, 2020 at 8:53 AM Dmitry Kozlyuk wrote: > > Add EAL private functions to support trace storage: > > * eal_persistent_data_path() > * eal_dir_create() > > Replace clock_gettime(CLOCK_REALTIME) with C11 timespec_get(). > Implementation is provided for MinGW-w64 that misses this functio