Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-03 Thread Bruce Richardson
On Thu, Jun 03, 2021 at 09:53:44AM +0200, David Marchand wrote: > On Thu, Jun 3, 2021 at 9:23 AM David Marchand > wrote: > > > > diff --git a/config/meson.build b/config/meson.build index > > > > 017bb2efbb..337daa2719 100644 --- a/config/meson.build +++ > > > > b/config/meson.build @@ -166,6 +166

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-03 Thread David Marchand
On Thu, Jun 3, 2021 at 9:23 AM David Marchand wrote: > > > diff --git a/config/meson.build b/config/meson.build > > > index 017bb2efbb..337daa2719 100644 > > > --- a/config/meson.build > > > +++ b/config/meson.build > > > @@ -166,6 +166,15 @@ if fdt_dep.found() and cc.has_header('fdt.h') > > >

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-03 Thread David Marchand
On Wed, Jun 2, 2021 at 11:19 PM Dmitry Kozlyuk wrote: > > 2021-06-02 11:58 (UTC+0200), David Marchand: > > Introduce an internal firmware loading helper to remove code duplication > > in our drivers and handle xz compressed firmwares by calling libarchive. > > > > This helper tries to look for .xz

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-02 Thread Dmitry Kozlyuk
2021-06-02 11:58 (UTC+0200), David Marchand: > Introduce an internal firmware loading helper to remove code duplication > in our drivers and handle xz compressed firmwares by calling libarchive. > > This helper tries to look for .xz suffixes so that drivers are not aware > the firmwares have been

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-02 Thread David Marchand
On Wed, Jun 2, 2021 at 1:13 PM Jerin Jacob wrote: > > +static int > > +firmware_read(const char *name, void **buf, size_t *bufsz) > > +{ > > + const size_t blocksize = 4096; > > + int ret = -1; > > + int err; > > +#ifdef RTE_HAS_LIBARCHIVE > > > I think, better to have small inli

Re: [dpdk-dev] [PATCH 2/2] eal: handle compressed firmwares

2021-06-02 Thread Jerin Jacob
On Wed, Jun 2, 2021 at 3:29 PM David Marchand wrote: > > Introduce an internal firmware loading helper to remove code duplication > in our drivers and handle xz compressed firmwares by calling libarchive. > > This helper tries to look for .xz suffixes so that drivers are not aware > the firmwares