Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-27 Thread Ye Xiaolong
On 09/27, Loftus, Ciara wrote: >[snip] > >> >+ >> >+static void >> >+configure_irqs(struct pmd_internals *internals, uint16_t rx_queue_id) >> >+{ >> >+ int coreid = internals->queue_irqs[rx_queue_id]; >> >+ char driver[NAME_MAX]; >> >+ uint16_t netdev_qid = rx_queue_id + internals->start_queu

Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-27 Thread Loftus, Ciara
[snip] > >+ > >+static void > >+configure_irqs(struct pmd_internals *internals, uint16_t rx_queue_id) > >+{ > >+int coreid = internals->queue_irqs[rx_queue_id]; > >+char driver[NAME_MAX]; > >+uint16_t netdev_qid = rx_queue_id + internals->start_queue_idx; > >+regex_t r; > >+int

Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-24 Thread Stephen Hemminger
On Thu, 19 Sep 2019 14:15:19 + Ciara Loftus wrote: > +char driver_array[NUM_DRIVERS][NAME_MAX] = {"i40e", "ixgbe", "mlx5_core"}; This only makes sense in this file. Should be static.

Re: [dpdk-dev] [PATCH 2/3] net/af_xdp: support pinning of IRQs

2019-09-24 Thread Ye Xiaolong
On 09/19, Ciara Loftus wrote: [snip] >+/* drivers supported for the queue_irq option */ >+enum {I40E_DRIVER, IXGBE_DRIVER, MLX5_DRIVER, NUM_DRIVERS}; Minor nit, how about using below format for readability and align with other enum type definition in DPDK? enum supported_driver { I40E_