Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-17 Thread Kadam, Pallavi
On 12/9/2020 12:59 AM, Thomas Monjalon wrote: 09/12/2020 01:21, Kadam, Pallavi: On 12/6/2020 7:49 AM, Thomas Monjalon wrote: 05/12/2020 02:10, Pallavi Kadam: --- a/lib/librte_eal/windows/include/rte_windows.h +++ b/lib/librte_eal/windows/include/rte_windows.h @@ -18,6 +18,11 @@ #define WI

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-09 Thread Thomas Monjalon
09/12/2020 01:21, Kadam, Pallavi: > On 12/6/2020 7:49 AM, Thomas Monjalon wrote: > > 05/12/2020 02:10, Pallavi Kadam: > >> --- a/lib/librte_eal/windows/include/rte_windows.h > >> +++ b/lib/librte_eal/windows/include/rte_windows.h > >> @@ -18,6 +18,11 @@ > >> #define WIN32_LEAN_AND_MEAN > >> #en

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-08 Thread Kadam, Pallavi
On 12/6/2020 7:49 AM, Thomas Monjalon wrote: 05/12/2020 02:10, Pallavi Kadam: --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -1,9 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -if is_windows - subdir_done() -endif drive

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-08 Thread Kadam, Pallavi
On 12/7/2020 1:14 AM, Bruce Richardson wrote: On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote: 05/12/2020 02:10, Pallavi Kadam: --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -1,9 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Cor

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-08 Thread Kadam, Pallavi
On 12/5/2020 5:52 AM, Dmitry Kozlyuk wrote: On Fri, 4 Dec 2020 17:10:19 -0800, Pallavi Kadam wrote: You could drop "add changes" and "i40e PMD" from subject line, as any commit changes something and topic is "net/i40e" already. Adding build changes to compile i40e PMD on windows. This is r

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-07 Thread Bruce Richardson
On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote: > 05/12/2020 02:10, Pallavi Kadam: > > --- a/drivers/net/meson.build > > +++ b/drivers/net/meson.build > > @@ -1,9 +1,6 @@ > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright(c) 2017 Intel Corporation > > > > -if is_window

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-06 Thread Thomas Monjalon
05/12/2020 02:10, Pallavi Kadam: > --- a/drivers/net/meson.build > +++ b/drivers/net/meson.build > @@ -1,9 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -if is_windows > - subdir_done() > -endif > > drivers = ['af_packet', > 'af_xdp',

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-05 Thread Dmitry Kozlyuk
On Fri, 4 Dec 2020 17:10:19 -0800, Pallavi Kadam wrote: You could drop "add changes" and "i40e PMD" from subject line, as any commit changes something and topic is "net/i40e" already. > Adding build changes to compile i40e PMD on windows. This is redundant given the commit subject. Please use p