Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-03-06 Thread Ferruh Yigit
On 3/6/2018 2:56 PM, Andrew Rybchenko wrote: > > In fact it could be really required if dynamic library is used and it is > pulled later using dlopen() - don't know if there are any restrictions in > DPDK which prevent it. That function has constructor attribute, not sure how it works for that ca

Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-03-06 Thread Andrew Rybchenko
On 03/06/2018 05:45 PM, Andrew Rybchenko wrote: On 03/05/2018 05:59 PM, Ferruh Yigit wrote: On 1/25/2018 5:00 PM, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton <...> @@ -2082,3 +2084,14 @@ RTE_PMD_REGISTER_PA

Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-03-06 Thread Andrew Rybchenko
On 03/05/2018 05:59 PM, Ferruh Yigit wrote: On 1/25/2018 5:00 PM, Andrew Rybchenko wrote: From: Ivan Malov Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton <...> @@ -2082,3 +2084,14 @@ RTE_PMD_REGISTER_PARAM_STRING(net_sfc_efx, SFC_KVARG_STATS_U

Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-03-05 Thread Ferruh Yigit
On 1/25/2018 5:00 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton <...> > @@ -2082,3 +2084,14 @@ RTE_PMD_REGISTER_PARAM_STRING(net_sfc_efx, > SFC_KVARG_STATS_UPDATE_PERIOD_MS "= " > SFC_KVA

Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-01-25 Thread Andrew Rybchenko
On 01/25/2018 09:42 PM, Stephen Hemminger wrote: On Thu, 25 Jan 2018 17:00:43 + Andrew Rybchenko wrote: diff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h index c7a54c3..8dd225e 100644 --- a/drivers/net/sfc/efsys.h +++ b/drivers/net/sfc/efsys.h @@ -26,6 +26,7 @@ #include

Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging

2018-01-25 Thread Stephen Hemminger
On Thu, 25 Jan 2018 17:00:43 + Andrew Rybchenko wrote: > diff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h > index c7a54c3..8dd225e 100644 > --- a/drivers/net/sfc/efsys.h > +++ b/drivers/net/sfc/efsys.h > @@ -26,6 +26,7 @@ > #include > > #include "sfc_debug.h" > +#include "s