Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path

2021-04-27 Thread David Marchand
On Tue, Apr 27, 2021 at 7:09 PM David Marchand wrote: > Investigating the other side (GUEST_ECN + the virtio pmd) could be > worth later, as I think GSO+ECN packets are dropped in the current > code. Errr, but that would be a problem only for vhost-kernel -> virtio pmd. Not sure this is a usecase

Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path

2021-04-27 Thread David Marchand
On Tue, Apr 13, 2021 at 5:27 PM Maxime Coquelin wrote: > On 4/8/21 8:38 PM, Flavio Leitner wrote: > > On Thu, Apr 01, 2021 at 11:52:43AM +0200, David Marchand wrote: > >> The vhost library current configures Tx offloading (PKT_TX_*) on any > >> packet received from a guest virtio device which asks

Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path

2021-04-13 Thread Maxime Coquelin
On 4/8/21 8:38 PM, Flavio Leitner wrote: > On Thu, Apr 01, 2021 at 11:52:43AM +0200, David Marchand wrote: >> The vhost library current configures Tx offloading (PKT_TX_*) on any >> packet received from a guest virtio device which asks for some offloading. >> >> This is problematic, as Tx offloa

Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path

2021-04-08 Thread Flavio Leitner
On Thu, Apr 01, 2021 at 11:52:43AM +0200, David Marchand wrote: > The vhost library current configures Tx offloading (PKT_TX_*) on any > packet received from a guest virtio device which asks for some offloading. > > This is problematic, as Tx offloading is something that the application > must ask

Re: [dpdk-dev] [PATCH 5/5] vhost: fix offload flags in Rx path

2021-04-08 Thread Olivier Matz
Hi David, On Thu, Apr 01, 2021 at 11:52:43AM +0200, David Marchand wrote: > The vhost library current configures Tx offloading (PKT_TX_*) on any > packet received from a guest virtio device which asks for some offloading. > > This is problematic, as Tx offloading is something that the application