Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-23 Thread Thomas Monjalon
23/05/2018 13:37, Yang, Zhiyong: > From: Yang, Zhiyong > > > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 22/05/2018 20:38, Ferruh Yigit: > > > > On 5/22/2018 2:12 PM, Thomas Monjalon wrote: > > > > > Any update to improve this workaround? > > > > > > > > > > 21/0

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-23 Thread Yang, Zhiyong
.@redhat.com; Bie, Tiwei ; > sta...@dpdk.org; Van Haaren, Harry > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for > vdevs > > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: W

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-22 Thread Yang, Zhiyong
.com; Bie, Tiwei ; > sta...@dpdk.org; Van Haaren, Harry > Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for > vdevs > > 22/05/2018 20:38, Ferruh Yigit: > > On 5/22/2018 2:12 PM, Thomas Monjalon wrote: > > > Any update to improve this wor

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-22 Thread Thomas Monjalon
22/05/2018 20:38, Ferruh Yigit: > On 5/22/2018 2:12 PM, Thomas Monjalon wrote: > > Any update to improve this workaround? > > > > 21/05/2018 18:38, Thomas Monjalon: > >> 21/05/2018 18:32, Ferruh Yigit: > >>> On 5/21/2018 11:54 AM, Thomas Monjalon wrote: > 19/05/2018 16:19, Thomas Monjalon: >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 2:12 PM, Thomas Monjalon wrote: > Any update to improve this workaround? > > 21/05/2018 18:38, Thomas Monjalon: >> 21/05/2018 18:32, Ferruh Yigit: >>> On 5/21/2018 11:54 AM, Thomas Monjalon wrote: 19/05/2018 16:19, Thomas Monjalon: > 18/05/2018 18:29, Ferruh Yigit: >> On

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-22 Thread Thomas Monjalon
Any update to improve this workaround? 21/05/2018 18:38, Thomas Monjalon: > 21/05/2018 18:32, Ferruh Yigit: > > On 5/21/2018 11:54 AM, Thomas Monjalon wrote: > > > 19/05/2018 16:19, Thomas Monjalon: > > >> 18/05/2018 18:29, Ferruh Yigit: > > >>> On 5/18/2018 4:55 PM, Matan Azrad wrote: > > Hi

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Thomas Monjalon
21/05/2018 18:44, Ferruh Yigit: > On 5/21/2018 5:40 PM, Thomas Monjalon wrote: > > 21/05/2018 18:37, Ferruh Yigit: > >> On 5/19/2018 3:19 PM, Thomas Monjalon wrote: > >>> 18/05/2018 18:29, Ferruh Yigit: > On 5/18/2018 4:55 PM, Matan Azrad wrote: > > Hi all > > > > While this patch

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Ferruh Yigit
On 5/21/2018 5:40 PM, Thomas Monjalon wrote: > 21/05/2018 18:37, Ferruh Yigit: >> On 5/19/2018 3:19 PM, Thomas Monjalon wrote: >>> 18/05/2018 18:29, Ferruh Yigit: On 5/18/2018 4:55 PM, Matan Azrad wrote: > Hi all > > While this patch also applied I don't understand it. > Is it

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Thomas Monjalon
21/05/2018 18:37, Ferruh Yigit: > On 5/19/2018 3:19 PM, Thomas Monjalon wrote: > > 18/05/2018 18:29, Ferruh Yigit: > >> On 5/18/2018 4:55 PM, Matan Azrad wrote: > >>> Hi all > >>> > >>> While this patch also applied I don't understand it. > >>> Is it mandatory for each PMD to free all its resources

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Thomas Monjalon
21/05/2018 18:32, Ferruh Yigit: > On 5/21/2018 11:54 AM, Thomas Monjalon wrote: > > 19/05/2018 16:19, Thomas Monjalon: > >> 18/05/2018 18:29, Ferruh Yigit: > >>> On 5/18/2018 4:55 PM, Matan Azrad wrote: > Hi all > > While this patch also applied I don't understand it. > Is it ma

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Ferruh Yigit
On 5/19/2018 3:19 PM, Thomas Monjalon wrote: > 18/05/2018 18:29, Ferruh Yigit: >> On 5/18/2018 4:55 PM, Matan Azrad wrote: >>> Hi all >>> >>> While this patch also applied I don't understand it. >>> Is it mandatory for each PMD to free all its resources in dev_close()? >>> Or it should be done by t

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Ferruh Yigit
On 5/21/2018 11:54 AM, Thomas Monjalon wrote: > 19/05/2018 16:19, Thomas Monjalon: >> 18/05/2018 18:29, Ferruh Yigit: >>> On 5/18/2018 4:55 PM, Matan Azrad wrote: Hi all While this patch also applied I don't understand it. Is it mandatory for each PMD to free all its resources i

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-21 Thread Thomas Monjalon
19/05/2018 16:19, Thomas Monjalon: > 18/05/2018 18:29, Ferruh Yigit: > > On 5/18/2018 4:55 PM, Matan Azrad wrote: > > > Hi all > > > > > > While this patch also applied I don't understand it. > > > Is it mandatory for each PMD to free all its resources in dev_close()? > > > Or it should be done by

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-19 Thread Thomas Monjalon
18/05/2018 18:29, Ferruh Yigit: > On 5/18/2018 4:55 PM, Matan Azrad wrote: > > Hi all > > > > While this patch also applied I don't understand it. > > Is it mandatory for each PMD to free all its resources in dev_close()? > > Or it should be done by the rte_device remove function? > > > > If the

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 4:55 PM, Matan Azrad wrote: > Hi all > > While this patch also applied I don't understand it. > Is it mandatory for each PMD to free all its resources in dev_close()? > Or it should be done by the rte_device remove function? > > If the resource cleanup should be done by the remove fu

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Matan Azrad
Hi all While this patch also applied I don't understand it. Is it mandatory for each PMD to free all its resources in dev_close()? Or it should be done by the rte_device remove function? If the resource cleanup should be done by the remove function I think it should be called for all the devices

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:18 AM, Iremonger, Bernard wrote: > Hi Ferruh, Zhiyong, > > > >>> Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs >>> >>> For vdev, just calling rte_eth_dev_close() isn't enough to free all >>> the resources allocated during device probe, e.g. for virtio-use

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Ferruh Yigit
On 5/18/2018 11:18 AM, Iremonger, Bernard wrote: > Hi Ferruh, Zhiyong, > > > >>> Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs >>> >>> For vdev, just calling rte_eth_dev_close() isn't enough to free all >>> the resources allocated during device probe, e.g. for virtio-use

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-18 Thread Iremonger, Bernard
Hi Ferruh, Zhiyong, > > Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs > > > > For vdev, just calling rte_eth_dev_close() isn't enough to free all > > the resources allocated during device probe, e.g. for virtio-user, > > virtio_user_pmd_remove(), i.e. the remove() method

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs

2018-05-17 Thread Yao, Lei A
> -Original Message- > From: Yang, Zhiyong > Sent: Friday, May 18, 2018 6:00 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; > Bie, Tiwei ; Yao, Lei A ; > Iremonger, Bernard ; sta...@dpdk.org; > Yang, Zhiyong > Subject: [PATCH v2] app/testpmd: fix pmd_test_exit fu