Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-08 Thread Wu, Jingjing
> > Right, i prefer the following though, what do you think? > >for (i = 0; i < RTE_MAX_LCORE; i++) { > sock_num = rte_lcore_to_socket_id(i); > if (new_socket_id(sock_num)) { > if (num_sockets >= RTE_MAX_NUMA_NODES) { >

Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-08 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: Wu, Jingjing [mailto:jingjing...@intel.com] > Sent: Monday, May 8, 2017 3:54 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Thomas Monjalon ; > sta...@dpdk.org > Subject: RE: [PATCH v2] app/testpmd: support non contiguous socket ids > > > > > -O

Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-07 Thread Wu, Jingjing
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Sunday, May 7, 2017 2:06 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Thomas Monjalon ; > sta...@dpdk.org > Subject: RE: [PATCH v2] app/testpmd: support non contiguous socket ids > > Saturday, May 6, 2017 4:41

Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-07 Thread Thomas Monjalon
03/05/2017 15:44, Shahaf Shuler: > + printf("Invalid socket id, options are: "); > + for (i = 0; i < num_sockets; i++) { > + printf("%u%s", socket_ids[i], > + (i == num_sockets - 1) ? "\n" : ","); [...]

Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-06 Thread Shahaf Shuler
Saturday, May 6, 2017 4:41 AM, Wu, Jingjing: > > > > The test assumes the socket ids are contiguous. This is not > > necessarily the case on all servers and may cause mempool creation to fail. > > > > Fixing it by detecting the list of valid socket ids and use it for the > > mempool creation. > > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-05 Thread Wu, Jingjing
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Wednesday, May 3, 2017 9:44 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; tho...@monjalon.net; sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: support non contiguous socket ids > > The test assumes the socke