Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 11:07 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 2 Apr 2019 23:03:06 +0200 > David Marchand wrote: > > > On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger < > > step...@networkplumber.org> wrote: > > > > > On Tue, 2 Apr 2019 22:15:40 +0200 > > > Dav

Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state

2019-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2019 23:03:06 +0200 David Marchand wrote: > On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > > > On Tue, 2 Apr 2019 22:15:40 +0200 > > David Marchand wrote: > > > > > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger < > > step...@netwo

Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 10:48 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 2 Apr 2019 22:15:40 +0200 > David Marchand wrote: > > > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger < > step...@networkplumber.org> > > wrote: > > > > > C language does not really treat enum's as

Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state

2019-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2019 22:15:40 +0200 David Marchand wrote: > On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger > wrote: > > > C language does not really treat enum's as first class symbols. > > The values in an enum live in a global namespace. That means if > > DPDK defines "RUNNING" it can't be u

Re: [dpdk-dev] [PATCH v2] eal: rename state values in rte_lcore_state

2019-04-02 Thread David Marchand
On Tue, Apr 2, 2019 at 5:57 PM Stephen Hemminger wrote: > C language does not really treat enum's as first class symbols. > The values in an enum live in a global namespace. That means if > DPDK defines "RUNNING" it can't be used by another enum in an > application using DPDK. > > To solve this