Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-14 Thread Adrien Mazarguil
On Wed, Nov 14, 2018 at 01:51:19PM +, Shahaf Shuler wrote: > IMO, it will make it more clear if the key will *have* to be null, because > there is no single good reason to have it otherwise. > > However it looks like an endless debate between strict and relaxed API. there > are points to b

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-14 Thread Shahaf Shuler
Wednesday, November 14, 2018 11:41 AM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > Hi Shahaf, > > On Tue, Nov 13, 2018 at 06:39:04PM +, Shahaf Shuler wrote: > > Hi Adrien, > > > > Tuesday, Novembe

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-14 Thread Adrien Mazarguil
Hi Shahaf, On Tue, Nov 13, 2018 at 06:39:04PM +, Shahaf Shuler wrote: > Hi Adrien, > > Tuesday, November 13, 2018 7:15 PM, Adrien Mazarguil: > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > > types > > > > Again a bit la

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Shahaf Shuler
Hi Adrien, Tuesday, November 13, 2018 7:15 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > Again a bit late to the party, please see below. > > On Sun, Nov 11, 2018 at 09:35:22AM +, Ori Kam wrote: [...] > &g

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Ophir Munk
> ; Shahaf Shuler ; Olga > Shern > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > Again a bit late to the party, please see below. > > On Sun, Nov 11, 2018 at 09:35:22AM +, Ori Kam wrote: > > > -Original Message- &g

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-13 Thread Adrien Mazarguil
; Andrew Rybchenko > > > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas Monjalon > > ; Asaf Penso ; Shahaf Shuler > > ; Olga Shern > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > > types > > > > > -Original Message

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-11 Thread Ori Kam
> > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas Monjalon > > ; Asaf Penso ; Shahaf > > Shuler ; Olga Shern > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > > types > > > > > > > On Nov 8, 2018, at 12:50 AM, Ophir Munk &

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-09 Thread Ophir Munk
gt;> Sent: Wednesday, November 07, 2018 6:41 PM > >> To: Ophir Munk > >> Cc: Ferruh Yigit ; Andrew Rybchenko > >> ; dev@dpdk.org; Thomas Monjalon > >> ; Asaf Penso ; Shahaf > Shuler > >> ; Olga Shern > >> Subject: Re: [dpdk-dev] [PATCH v2] et

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-08 Thread Yongseok Koh
bchenko >> ; dev@dpdk.org; Thomas Monjalon >> ; Asaf Penso ; Shahaf >> Shuler ; Olga Shern >> Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and >> types >> >> On Wed, Nov 07, 2018 at 03:13:07PM +, Ophir Munk wrote: >>> &

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-08 Thread Ophir Munk
> Sent: Wednesday, November 07, 2018 4:06 PM > > > To: Ophir Munk > > > Cc: Ferruh Yigit ; Andrew Rybchenko > > > ; dev@dpdk.org; Thomas Monjalon > > > ; Asaf Penso ; Shahaf > > > Shuler ; Olga Shern > > > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-07 Thread Andrew Rybchenko
@dpdk.org; Thomas Monjalon ; Asaf Penso ; Shahaf Shuler ; Olga Shern Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types On Wed, Nov 07, 2018 at 12:39:24PM +, Ophir Munk wrote: -Original Message- From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] Sent

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-07 Thread Adrien Mazarguil
chenko > > ; dev@dpdk.org; Thomas Monjalon > > ; Asaf Penso ; Shahaf > > Shuler ; Olga Shern > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > > types > > > > On Wed, Nov 07, 2018 at 12:39:24PM +, Ophir Munk wrote: > > &g

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-07 Thread Ophir Munk
ent: Wednesday, November 07, 2018 11:31 AM > > > To: Ophir Munk > > > Cc: Ferruh Yigit ; Andrew Rybchenko > > > ; dev@dpdk.org; Thomas Monjalon > > > ; Asaf Penso ; Shahaf > > > Shuler ; Olga Shern > > > Subject: Re: [dpdk-dev] [PATCH v2] et

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-07 Thread Adrien Mazarguil
> ; dev@dpdk.org; Thomas Monjalon > > ; Asaf Penso ; Shahaf > > Shuler ; Olga Shern > > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > > types > > > > On Wed, Nov 07, 2018 at 09:23:42AM +, Ophir Munk wrote: > > > st

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-07 Thread Ophir Munk
> Subject: Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and > types > > On Wed, Nov 07, 2018 at 09:23:42AM +, Ophir Munk wrote: > > struct rte_flow_action_rss include fields 'key' and 'types'. > > Field 'key' is a pointer to b

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-07 Thread Adrien Mazarguil
On Wed, Nov 07, 2018 at 09:23:42AM +, Ophir Munk wrote: > struct rte_flow_action_rss include fields 'key' and 'types'. > Field 'key' is a pointer to bytes array (uint8_t *) which contains the > specific RSS hash key. > If an application is only interested in default RSS operation it > should no