Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-19 Thread Thomas Monjalon
12/04/2019 16:52, Ferruh Yigit: > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > > It allows applications running packet sockets over KNI interfaces to get > > source Ethernet addresses of packets received using recvfrom function. > > > > Signed-off-by: Igor Ryzhov > > Acked-by: Ferruh Yigit Appl

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-15 Thread Ferruh Yigit
On 4/15/2019 9:37 AM, Igor Ryzhov wrote: > Hi Ferruh, > > To be absolutely sure, I performed a test using the test application. > > When I send pings from an interface: > 3: ens8: mtu 1500 qdisc pfifo_fast state > UP mode DEFAULT group default qlen 1000 > link/ether 52:54:00:c8:79:c6 brd ff:

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-15 Thread Igor Ryzhov
Hi Ferruh, To be absolutely sure, I performed a test using the test application. When I send pings from an interface: 3: ens8: mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000 link/ether 52:54:00:c8:79:c6 brd ff:ff:ff:ff:ff:ff Here is what's in sockaddr_ll: $2 = {sll_

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 6:12 PM, Igor Ryzhov wrote: > Hi Ferruh, > > I didn't test it with any special application, but FRR's ISIS works for me > after > the patch, and it didn't work before. That is good enough, and by work you mean that you are able to get correct value on 'sll_addr', right? > > Igor >

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Igor Ryzhov
Hi Ferruh, I didn't test it with any special application, but FRR's ISIS works for me after the patch, and it didn't work before. Igor On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit wrote: > On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > >> It allows ap

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: >> It allows applications running packet sockets over KNI interfaces to get >> source Ethernet addresses of packets received using recvfrom function. >> >> Signed-off-by: Igor Ryzhov > > Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > It allows applications running packet sockets over KNI interfaces to get > source Ethernet addresses of packets received using recvfrom function. > > Signed-off-by: Igor Ryzhov Acked-by: Ferruh Yigit Hi Igor, I tested this with a quick application