Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2018-01-19 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, January 19, 2018 5:07 PM > To: Xueming(Steven) Li > Cc: Adrien Mazarguil ; dev@dpdk.org > Subject: Re: [PATCH v2] lib/cmdline: init CLI parsing memory > > On Thu, Jan 18, 2018 at 04:29:59AM +,

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2018-01-19 Thread Olivier Matz
On Thu, Jan 18, 2018 at 04:29:59AM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Tuesday, January 16, 2018 8:46 PM > > To: Xueming(Steven) Li > > Cc: Adrien Mazarguil ; dev@dpdk.org > > Subject: Re: [PATCH v2]

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2018-01-17 Thread Xueming(Steven) Li
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, January 16, 2018 8:46 PM > To: Xueming(Steven) Li > Cc: Adrien Mazarguil ; dev@dpdk.org > Subject: Re: [PATCH v2] lib/cmdline: init CLI parsing memory > > Hi Xueming, > > Sorry for the late respo

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2018-01-16 Thread Olivier Matz
Hi Xueming, Sorry for the late response. On Tue, Dec 26, 2017 at 12:57:41PM +, Xueming(Steven) Li wrote: > HI Olivier, > > By reading p1 comments carefully, looks like the pointer to result buffer > issue > not resolved by result copy. How about this: > > @@ -263,6 +263,7 @@ > #ifdef RTE_

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2017-12-26 Thread Xueming(Steven) Li
HI Olivier, By reading p1 comments carefully, looks like the pointer to result buffer issue not resolved by result copy. How about this: @@ -263,6 +263,7 @@ #ifdef RTE_LIBRTE_CMDLINE_DEBUG char debug_buf[BUFSIZ]; #endif + char *result_buf = result.buf; if (!cl || !buf)

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2017-12-18 Thread Xueming(Steven) Li
No problem, make enough sense for v3. > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, December 18, 2017 6:51 PM > To: Olivier MATZ > Cc: Xueming(Steven) Li ; dev@dpdk.org > Subject: Re: [PATCH v2] lib/cmdline: init CLI parsing memory > >

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2017-12-18 Thread Adrien Mazarguil
On Thu, Dec 14, 2017 at 04:35:45PM +0100, Olivier MATZ wrote: > Hi Xueming, > > On Sat, Dec 09, 2017 at 11:39:23PM +0800, Xueming Li wrote: > > Initialize result memory every time before parsing. Also save > > successfully parsed result before further ambiguous command detection to > > avoid resul

Re: [dpdk-dev] [PATCH v2] lib/cmdline: init CLI parsing memory

2017-12-14 Thread Olivier MATZ
Hi Xueming, On Sat, Dec 09, 2017 at 11:39:23PM +0800, Xueming Li wrote: > Initialize result memory every time before parsing. Also save > successfully parsed result before further ambiguous command detection to > avoid result being tainted by later parsing. > > Signed-off-by: Xueming Li I'm ok