Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Thomas Monjalon
18/04/2019 19:09, Adrien Mazarguil: > On Thu, Apr 18, 2019 at 06:54:22PM +0200, Thomas Monjalon wrote: > > > > > > > > > "slave" is a wording from bonding. > > > > > In failsafe, it is sub-device, isn't it? > > > > > > I don't mind, although grep shows a couple of comments talking about > > > s

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Adrien Mazarguil
On Thu, Apr 18, 2019 at 06:54:22PM +0200, Thomas Monjalon wrote: > > > > > > "slave" is a wording from bonding. > > > > In failsafe, it is sub-device, isn't it? > > > > I don't mind, although grep shows a couple of comments talking about slaves > > already. Either way I think it fits as those ar

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Thomas Monjalon
18/04/2019 18:46, Adrien Mazarguil: > On Thu, Apr 18, 2019 at 05:51:18PM +0200, Thomas Monjalon wrote: > > 18/04/2019 17:39, Thomas Monjalon: > > > 18/04/2019 17:32, Adrien Mazarguil: > > > > When passed to the application, Rx packets retain the port ID value > > > > originally set by slave devices

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Adrien Mazarguil
On Thu, Apr 18, 2019 at 05:51:18PM +0200, Thomas Monjalon wrote: > 18/04/2019 17:39, Thomas Monjalon: > > 18/04/2019 17:32, Adrien Mazarguil: > > > When passed to the application, Rx packets retain the port ID value > > > originally set by slave devices. Unfortunately these IDs have no meaning > >

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Gaƫtan Rivet
On Thu, Apr 18, 2019 at 05:39:37PM +0200, Thomas Monjalon wrote: > 18/04/2019 17:32, Adrien Mazarguil: > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically unawar

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Thomas Monjalon
18/04/2019 17:39, Thomas Monjalon: > 18/04/2019 17:32, Adrien Mazarguil: > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically unaware of their existence. > > > >

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Thomas Monjalon
18/04/2019 17:32, Adrien Mazarguil: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuses those caring about the source po