Re: [dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device

2020-10-12 Thread Thomas Monjalon
12/10/2020 22:58, Harris, James R: > > On 10/7/20, 8:06 AM, "Thomas Monjalon" wrote: > > Hi Jim, > > Sorry I see nobody reviewed your patch. > > Jim Harris wrote: > > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id)); > [...] > > + memcmp(&dev2->id, &dev->id, sizeof(dev

Re: [dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device

2020-10-12 Thread Harris, James R
On 10/7/20, 8:06 AM, "Thomas Monjalon" wrote: Hi Jim, Sorry I see nobody reviewed your patch. Jim Harris wrote: > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id)); [...] > + memcmp(&dev2->id, &dev->id, sizeof(dev2->id))) Why using memcpy and memcmp instead of sim

Re: [dpdk-dev] [PATCH v2] pci/linux: copy new id for inserted device

2020-10-07 Thread Thomas Monjalon
Hi Jim, Sorry I see nobody reviewed your patch. Jim Harris wrote: > + memcpy(&dev2->id, &dev->id, sizeof(dev2->id)); [...] > + memcmp(&dev2->id, &dev->id, sizeof(dev2->id))) Why using memcpy and memcmp instead of simple assignment and comparison?