Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-10 Thread Jerin Jacob
On Fri, Apr 10, 2020 at 3:33 PM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Saturday, April 4, 2020 9:58 PM > > > > 04/04/2020 20:30, Andrzej Ostruszka [C]: > > > Thomas, > > > > > > I have replied to the other mail, here I just want to confirm, that >

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Saturday, April 4, 2020 12:19 PM > [...] > Since it is the control plane, slow path traffic without any > performance requirement, This is incorrect. Production equipment certainly has control plane performance requirem

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-10 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, April 4, 2020 9:58 PM > > 04/04/2020 20:30, Andrzej Ostruszka [C]: > > Thomas, > > > > I have replied to the other mail, here I just want to confirm, that > I'm > > fine with the proposed "general messaging" which other librari

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-04 Thread Thomas Monjalon
04/04/2020 20:30, Andrzej Ostruszka [C]: > Thomas, > > I have replied to the other mail, here I just want to confirm, that I'm > fine with the proposed "general messaging" which other libraries (IF > Proxy including) could utilize. > > See also below. > > On 4/3/20 7:19 PM, Thomas Monjalon wrote

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-04 Thread Thomas Monjalon
04/04/2020 20:07, Andrzej Ostruszka [C]: > On 4/3/20 11:42 PM, Thomas Monjalon wrote: > > 10/03/2020 12:10, Andrzej Ostruszka: > [...] > >> The purpose of this library is to help with both of these tasks (as long > >> as they remain in domain of configuration available to the system). In > >> othe

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-04 Thread Andrzej Ostruszka [C]
Thomas, I have replied to the other mail, here I just want to confirm, that I'm fine with the proposed "general messaging" which other libraries (IF Proxy including) could utilize. See also below. On 4/3/20 7:19 PM, Thomas Monjalon wrote: > 02/04/2020 15:48, Andrzej Ostruszka [C]: >> On 3/26/20

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-04 Thread Andrzej Ostruszka [C]
First of all Thomas, thank you for taking time to look at this. Please scroll below for my comments. It looks like we are going to detour a bit for a general config mechanism on top of which we can "rebase" IF Proxy and other libs/apps. Note - since I often like to think in concrete terms I migh

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-04 Thread Jerin Jacob
On Sat, Apr 4, 2020 at 3:27 AM Thomas Monjalon wrote: > > 03/04/2020 23:18, Morten Brørup: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > > Thomas Monjalon wrote: > > > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > > > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > >

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Thomas Monjalon
03/04/2020 23:18, Morten Brørup: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Thomas Monjalon wrote: > > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > > > > On 3/25/20 12:11 PM, Morten Brørup wrote: > > > > [...] > > >

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Thomas Monjalon
Hi Andrzej, Thanks for the very good explanations in the cover letter. I have several comments and questions about the design. I think IF proxy is a good idea which should be part of a bigger plan. 10/03/2020 12:10, Andrzej Ostruszka: > What is this useful for > === > > Usua

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Friday, April 3, 2020 9:09 PM > > On Fri, Apr 3, 2020 at 10:49 PM Thomas Monjalon > wrote: > > > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > > > On 3/25/20 12:11 PM, Mo

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Jerin Jacob
On Fri, Apr 3, 2020 at 10:49 PM Thomas Monjalon wrote: > > 02/04/2020 15:48, Andrzej Ostruszka [C]: > > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > > On 3/25/20 12:11 PM, Morten Brørup wrote: > > [...] > > >> And I am still strongly opposed to the callback method: > > > > > > Noted - however

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-03 Thread Thomas Monjalon
02/04/2020 15:48, Andrzej Ostruszka [C]: > On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > > On 3/25/20 12:11 PM, Morten Brørup wrote: > [...] > >> And I am still strongly opposed to the callback method: > > > > Noted - however for now I would like to keep them. I don't have much > > experience wi

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-04-02 Thread Andrzej Ostruszka [C]
On 3/26/20 6:42 PM, Andrzej Ostruszka wrote: > On 3/25/20 12:11 PM, Morten Brørup wrote: [...] >> And I am still strongly opposed to the callback method: > > Noted - however for now I would like to keep them. I don't have much > experience with this library so if they prove to be inadequate then

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-30 Thread Andrzej Ostruszka
On 3/26/20 1:41 PM, Andrzej Ostruszka wrote: > Thank you David for taking time to look at this. > > On 3/25/20 9:08 AM, David Marchand wrote: >> Hello Andrzej, >> >> On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka > [...] >> I can see we end up exposing structures for registering callbacks. >

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-26 Thread Andrzej Ostruszka
On 3/25/20 12:11 PM, Morten Brørup wrote: [...] >>> - Notification scheme has been changed - instead of having just >>> callbacks now event queueing is also available (or a mix of those >>> two). > > Thank you for adding event queueing! That was actually a good input from you - thank you. >

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-26 Thread Andrzej Ostruszka
Thank you David for taking time to look at this. On 3/25/20 9:08 AM, David Marchand wrote: > Hello Andrzej, > > On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka [...] > I can see we end up exposing structures for registering callbacks. Right. I was thinking more in terms of user convenience s

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-25 Thread Morten Brørup
Andrzej, > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Wednesday, March 25, 2020 9:08 AM > > Hello Andrzej, > > On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka > wrote: > > > > > > What has changed since the RFC > > == > > > > -

Re: [dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-25 Thread David Marchand
Hello Andrzej, On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka wrote: > > What is this useful for > === > > Usually, when an ethernet port is assigned to DPDK it vanishes from the > system and user looses ability to control it via normal configuration > utilities (e.g. thos