Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-06 Thread Ori Kam
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Wednesday, October 7, 2020 3:50 AM > Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe > > > > > -Original Message- > > From: Ajit Khaparde > > S

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-06 Thread Ajit Khaparde
> > +static inline void > > +flow_lock(struct rte_eth_dev *dev) > > Maybe change the name to flow_safe_enter > Since this function doesn't always lock. I feel fts_enter() sounds better. > > > +{ > > + if (!(dev->data->dev_flags & > > RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE)) > > + pthread

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-06 Thread Suanming Mou
ject: Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread > safe > > > > +static inline void > > > +flow_lock(struct rte_eth_dev *dev) > > > > Maybe change the name to flow_safe_enter > > Since this function doesn't always lock. > I fee

Re: [dpdk-dev] [PATCH v2 2/2] ethdev: make rte_flow API thread safe

2020-10-05 Thread Ori Kam
Hi Suanming, PSB, Best, Ori > -Original Message- > From: Suanming Mou > Subject: [PATCH v2 2/2] ethdev: make rte_flow API thread safe > > Currently, the rte_flow functions are not defined as thread safe. > DPDK applications either call the functions in single thread or add > locks aroun