Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-09 Thread Zhang, Tianfei
> .../raw/ifpga_rawdev/base/ifpga_enumerate.c | 8 ++-- > .../raw/ifpga_rawdev/base/ifpga_feature_dev.h | 8 ++-- > drivers/raw/ifpga_rawdev/base/ifpga_port.c| 6 +-- > .../raw/ifpga_rawdev/base/ifpga_port_error.c | 2 +- For ifpga_rawdev part, it looks good for me. Acked-by: Tianfei z

Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-08 Thread Shreyansh Jain
On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: Some global variables are defined with generic names, add component name as prefix to variables to prevent collusion with application variables. Signed-off-by: Ferruh Yigit --- drivers/bus/dpaa/include/fsl_fman_crc64.h | 8 ++-- [.

Re: [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name

2018-10-05 Thread Maxime Coquelin
On 10/05/2018 06:26 PM, Ferruh Yigit wrote: drivers/net/virtio/virtio_user/vhost.h| 4 +- drivers/net/virtio/virtio_user/vhost_kernel.c | 2 +- drivers/net/virtio/virtio_user/vhost_user.c | 2 +- For the virtio-user part: Reviewed-by: Maxime Coquelin Thanks, Maxime