Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-05 Thread Varghese, Vipin
> -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, December 6, 2018 11:29 AM > To: Varghese, Vipin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build > > Hi Vipin, > > > > -Original Message- &

Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-05 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Thursday, December 6, 2018 12:31 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build > > Hi Wenzhuo > > snipped > > > > > &g

Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-05 Thread Varghese, Vipin
Hi Wenzhuo snipped > > > > Should not meson build option be add start. That is in patch 1/20 so > > compile options does not fail? > It will not fail. Enabling the compile earlier only means the code can be > compiled. > But, to use this device we do need the whole patch set. From this point of

Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-04 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Monday, December 3, 2018 6:01 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build > > Should not meson build option be add s

Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-03 Thread Varghese, Vipin
Should not meson build option be add start. That is in patch 1/20 so compile options does not fail? Thanks Vipin Varghese