Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Dmitry Kozlyuk
On Sun, 21 Feb 2021 11:58:39 +, Tal Shnaiderman wrote: [...] > > Thanks for all your comments, it's weird I didn't hit the failures locally. > > Will fix in v3. > > You might be missing the DevX SDK installation, without it meson will skip > the mlx5 build. > > You can get it either by in

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX > symbols > > External email: Use caution opening links or attachments > > > On Sun, 21 Feb 2021 08:59:50 +, Tal Shnaiderman wrote: > [...] > > > -#ifndef close > > > -#defi

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Dmitry Kozlyuk
On Sun, 21 Feb 2021 08:59:50 +, Tal Shnaiderman wrote: [...] > > -#ifndef close > > -#define close _close > > -#endif > > mlx5 uses close() in mlx5.c and is broken after this change above, BTW why > not add an rte_close instead of local definition? I'm reluctant to add file manipulation AP

Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols

2021-02-21 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX > symbols > > External email: Use caution opening links or attachments > > > Exposing POSIX symbols could break consumer POSIX compatibility code. > > * Make renaming of close() and unlink() private to EAL. > > * Remove rena