Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-21 Thread David Marchand
On Thu, Oct 14, 2021 at 7:55 PM Vladimir Medvedkin wrote: > > This patch fixes buffer overflow reported by ASAN, > please reference https://bugs.dpdk.org/show_bug.cgi?id=818 > > Some tests for the rte_hash table use the rte_jhash_32b() as > the hash function. This hash function interprets the leng

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-20 Thread Wang, Yipeng1
> -Original Message- > From: David Marchand > Sent: Wednesday, October 20, 2021 12:54 PM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Cc: dev ; dpdk stable ; Medvedkin, > Vladimir > Subject: Re: [PATCH v3] test/hash: fix buffer overflow > > On Tue, Oct 19, 2021 at 5:58

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-20 Thread David Marchand
On Tue, Oct 19, 2021 at 5:58 PM Medvedkin, Vladimir wrote: > > I am not against the fix, but it seems to test something different > > than what an application using the hash library would do. > > Or if an application directly calls this hash function, maybe the unit > > test should not test it via

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-19 Thread Medvedkin, Vladimir
Hi David, On 19/10/2021 09:02, David Marchand wrote: On Fri, Oct 15, 2021 at 3:02 PM Medvedkin, Vladimir wrote: I am confused. Does it mean that rte_jhash_32b is not compliant with rte_hash_create API? I think so too, because despite the fact that the ABI is the same, the API remains differ

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-19 Thread David Marchand
On Fri, Oct 15, 2021 at 3:02 PM Medvedkin, Vladimir wrote: > > I am confused. > > Does it mean that rte_jhash_32b is not compliant with rte_hash_create API? > > > > I think so too, because despite the fact that the ABI is the same, the > API remains different with respect to the length argument.

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-15 Thread Medvedkin, Vladimir
Hi David, On 15/10/2021 11:33, David Marchand wrote: On Thu, Oct 14, 2021 at 7:55 PM Vladimir Medvedkin wrote: @@ -1607,6 +1611,17 @@ static struct rte_hash_parameters hash_params_ex = { }; /* + * Wrapper function around rte_jhash_32b. + * It is required because rte_jhash_32b() accepts th

Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow

2021-10-15 Thread David Marchand
On Thu, Oct 14, 2021 at 7:55 PM Vladimir Medvedkin wrote: > @@ -1607,6 +1611,17 @@ static struct rte_hash_parameters hash_params_ex = { > }; > > /* > + * Wrapper function around rte_jhash_32b. > + * It is required because rte_jhash_32b() accepts the length > + * as size of 4-byte units. > + */ >