Re: [dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd strlcpy

2018-05-13 Thread Andy Green
On 05/13/2018 10:56 PM, Thomas Monjalon wrote: Hi, 12/05/2018 03:58, Andy Green: Signed-off-by: Andy Green Why do we need to replace rte_strlcpy fallback? GCC 8 complains about the fallback using snprintf? No; the first version of this patch just fixed the compiler warnings. But Stephen

Re: [dpdk-dev] [PATCH v3 01/24] lib/librte_eal: import libbsd strlcpy

2018-05-13 Thread Thomas Monjalon
Hi, 12/05/2018 03:58, Andy Green: > Signed-off-by: Andy Green Why do we need to replace rte_strlcpy fallback? GCC 8 complains about the fallback using snprintf? > +/* > + * Copyright (c) 1998 Todd C. Miller > + * > + * Permission to use, copy, modify, and distribute this software for any > +