Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-15 Thread Bruce Richardson
On Wed, Sep 15, 2021 at 12:12:34PM +0200, Maxime Coquelin wrote: > Hi Kevin, > > On 9/8/21 12:30 PM, Kevin Laatz wrote: > > Add the basic device probing for DSA devices bound to the IDXD kernel > > driver. These devices can be configured via sysfs and made available to > > DPDK if they are found d

Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-15 Thread Maxime Coquelin
Hi Kevin, On 9/8/21 12:30 PM, Kevin Laatz wrote: > Add the basic device probing for DSA devices bound to the IDXD kernel > driver. These devices can be configured via sysfs and made available to > DPDK if they are found during bus scan. Relevant documentation is included. > > Signed-off-by: Bruce

Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-09 Thread Kevin Laatz
On 08/09/2021 17:47, Conor Walsh wrote: +static void * +idxd_vdev_mmap_wq(struct rte_dsa_device *dev) Some inconsistent naming between vdev and bus in some of these functions the above should be idxd_bus_mmap_wq for example. Will fix in v4, thanks.

Re: [dpdk-dev] [PATCH v3 04/17] dma/idxd: add bus device probing

2021-09-08 Thread Conor Walsh
+static void * +idxd_vdev_mmap_wq(struct rte_dsa_device *dev) Some inconsistent naming between vdev and bus in some of these functions the above should be idxd_bus_mmap_wq for example. +{ + void *addr; + char path[PATH_MAX]; + int fd; + + snprintf(path, sizeof(pa